Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: chrome/renderer/extensions/extension_helper.cc

Issue 11571014: Lazy load chrome.* APIs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: windows interactive_ui_tests fix Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/extension_helper.cc
diff --git a/chrome/renderer/extensions/extension_helper.cc b/chrome/renderer/extensions/extension_helper.cc
index c97c22a239fa6c1eb88211b4be1d8f9a75ea20b6..c0e513d5bb30bc4d5e7373214b7311a560d4abe4 100644
--- a/chrome/renderer/extensions/extension_helper.cc
+++ b/chrome/renderer/extensions/extension_helper.cc
@@ -509,8 +509,7 @@ void ExtensionHelper::DidDownloadApplicationIcon(ImageResourceFetcher* fetcher,
if (current_size > kMaxIconSize - actual_icon_size) {
AddMessageToRootConsole(
content::CONSOLE_MESSAGE_LEVEL_ERROR,
- ASCIIToUTF16("Icons are too large. "
- "Maximum total size for app icons is 128 KB."));
+ "Icons are too large. Maximum total size for app icons is 128 KB.");
return;
}
actual_icon_size += current_size;
@@ -522,6 +521,11 @@ void ExtensionHelper::DidDownloadApplicationIcon(ImageResourceFetcher* fetcher,
}
void ExtensionHelper::AddMessageToRootConsole(ConsoleMessageLevel level,
+ const std::string& message) {
+ AddMessageToRootConsole(level, ASCIIToUTF16(message));
+}
+
+void ExtensionHelper::AddMessageToRootConsole(ConsoleMessageLevel level,
const string16& message) {
if (render_view()->GetWebView() && render_view()->GetWebView()->mainFrame()) {
WebConsoleMessage::Level target_level = WebConsoleMessage::LevelLog;

Powered by Google App Engine
This is Rietveld 408576698