Lazy load chrome.* APIs

chrome/renderer/extensions/binding_generating_native_handler.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/renderer/extensions/binding_generating_native_handler.h"
+
+#include "chrome/renderer/extensions/module_system.h"
+#include "chrome/renderer/extensions/v8_schema_registry.h"
+
+namespace extensions {
+
+BindingGeneratingNativeHandler::BindingGeneratingNativeHandler(
+    ModuleSystem* module_system,
+    V8SchemaRegistry* schema_registry,
+    const std::string& api_name,
+    const std::string& bind_to)
+    : module_system_(module_system),
+      schema_registry_(schema_registry),

[not at google - send to devlin, 2013/02/13 01:45:49]

schema_registry unused?

[cduvall, 2013/02/15 00:40:28]

Done.

+      api_name_(api_name),
+      bind_to_(bind_to) {
+}
+
+v8::Handle<v8::Object> BindingGeneratingNativeHandler::NewInstance() {
+  v8::Handle<v8::Object> binding = v8::Handle<v8::Object>::Cast(
+      v8::Handle<v8::Object>::Cast(module_system_->Require(
+          "binding"))->Get(v8::String::New("Binding")));
+  v8::Handle<v8::Function> create = v8::Handle<v8::Function>::Cast(
+      binding->Get(v8::String::New("create")));
+  v8::Handle<v8::Value> argv[] = { v8::String::New(api_name_.c_str()) };
+  v8::Handle<v8::Object> binding_instance = v8::Handle<v8::Object>::Cast(
+      create->Call(binding, 1, argv));
+  v8::Handle<v8::Function> generate = v8::Handle<v8::Function>::Cast(
+      binding_instance->Get(v8::String::New("generate")));
+  v8::Handle<v8::Value> compiled_schema;
+  {
+    v8::TryCatch try_catch;
+    compiled_schema = generate->Call(binding_instance, 0, NULL);
+    if (try_catch.HasCaught()) {
+      module_system_->LogExceptionToConsole(try_catch);

[not at google - send to devlin, 2013/02/13 01:45:49]

Doesn't seem like it should be module system's responsibility to provide this,
just call the ExtensionHelper class directly? Or pull it out into a separate
class, but using ExtensionHelper is simpler...

[cduvall, 2013/02/15 00:40:28]

Now the exception is logged in binding.js.

+      return v8::Object::New();
+    }
+  }
+  v8::Handle<v8::Object> object = v8::Object::New();
+  object->Set(v8::String::New(bind_to_.c_str()), compiled_schema);

[not at google - send to devlin, 2013/02/13 01:45:49]

I'll need to get koz@ to look at this, I think this needs to be a v8::Local with
a handlescope so that it doesn't leak? I can't remember how v8 refcounting works
in the APIs.

[koz (OOO until 15th September), 2013/02/14 06:21:13]

You don't need to declare it a v8::Local, but it would be prudent to surround
this function with a

v8::HandleScope scope;
...
return scope.Close(object);

When a v8::HandleScope goes out of scope it will mark as garbage any new v8
objects declared while it was alive (unless a later v8::HandleScope is
introduced).

For this function I suspect there's probably a higher v8::HandleScope that will
be capturing all these variables, but better safe than sorry I guess.

[cduvall, 2013/02/15 00:40:28]

Done.

+  return object;
+}
+
+} // extensions