Lazy load chrome.* APIs

chrome/common/extensions/api/extension_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/api/extension_api.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 567 matching lines @@
     if (!IsFeatureAllowedForExtension(*i, extension)) {
       apis->erase(i++);
     } else {
       ++i;
     }
   }
 }
 
 }  // namespace
 
-scoped_ptr<std::set<std::string> > ExtensionAPI::GetAPIsForContext(
+std::set<std::string> ExtensionAPI::GetAPIsForContext(
     Feature::Context context, const Extension* extension, const GURL& url) {
   // We're forced to load all schemas now because we need to know the metadata
   // about every API -- and the metadata is stored in the schemas themselves.
   // This is a shame.
   // TODO(aa/kalman): store metadata in a separate file and don't load all
   // schemas.
   LoadAllSchemas();
 
   std::set<std::string> temp_result;
 
@@ skipping 24 matching lines @@
     case Feature::UNBLESSED_EXTENSION_CONTEXT:
     case Feature::CONTENT_SCRIPT_CONTEXT:
       if (extension) {
         // Same as BLESSED_EXTENSION_CONTEXT, but only those APIs that are
         // unprivileged.
         GetAllowedAPIs(extension, &temp_result);
         // Resolving dependencies before removing unprivileged APIs means that
         // some unprivileged APIs may have unrealised dependencies. Too bad!
         ResolveDependencies(&temp_result);
         RemovePrivilegedAPIs(&temp_result);
+        // TODO(cduvall): In DevTools.js:71777, there is a check if chrome has
+        // a getter for devtools. This is true, and then
+        // chrome.devtools.inspectedWindow is used. If devtools is not
+        // available, it is true that chrome has a getter for devtools, but the
+        // getter will return undefined in content scripts. This makes sure
+        // chrome.devtools is available everywhere.

[not at google - send to devlin, 2013/02/13 01:45:49]

... but even for extensions that don't have the devtools permission?

I still can't parse the comment, sorry :(

[cduvall, 2013/02/15 00:40:28]

Took this out, because it works with a change in WebKit.

+        temp_result.insert("devtools");
       }
       break;
 
     case Feature::WEB_PAGE_CONTEXT:
       if (url.is_valid()) {
         // Availablility is determined by the url.
         GetAPIsMatchingURL(url, &temp_result);
       }
       break;
   }
 
   // Filter out all non-API features and remove the feature type part of the
   // name.
-  scoped_ptr<std::set<std::string> > result(new std::set<std::string>());
+  std::set<std::string> result;
   for (std::set<std::string>::iterator iter = temp_result.begin();
        iter != temp_result.end(); ++iter) {
     std::string feature_type;
     std::string feature_name;
     SplitDependencyName(*iter, &feature_type, &feature_name);
     if (feature_type == "api")
-      result->insert(feature_name);
+      result.insert(feature_name);
   }
 
-  return result.Pass();
+  return result;
+}
+
+std::set<std::string> ExtensionAPI::GetAllAPINames() {
+  std::set<std::string> result;
+  for (SchemaMap::iterator i = schemas_.begin(); i != schemas_.end(); ++i)
+    result.insert(i->first);
+  for (UnloadedSchemaMap::iterator i = unloaded_schemas_.begin();
+       i != unloaded_schemas_.end(); ++i) {
+    result.insert(i->first);
+  }
+  return result;
 }
 
 Feature* ExtensionAPI::GetFeature(const std::string& full_name) {
   // Ensure it's loaded.
   GetSchema(full_name);
 
   std::string child_name;
   std::string api_namespace = GetAPINameFromFullName(full_name, &child_name);
 
   APIFeatureMap::iterator feature_map = features_.find(api_namespace);
@@ skipping 152 matching lines @@
 
 void ExtensionAPI::LoadAllSchemas() {
   while (unloaded_schemas_.size()) {
     std::map<std::string, base::StringPiece>::iterator it =
         unloaded_schemas_.begin();
     LoadSchema(it->first, it->second);
   }
 }
 
 }  // namespace extensions