Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1157093004: Added Usage instructions (Closed)

Created:
5 years, 6 months ago by vsm
Modified:
5 years, 6 months ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 5

Patch Set 2 : Fix typo #

Patch Set 3 : Minor fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -0 lines) Patch
M README.md View 1 chunk +2 lines, -0 lines 0 comments Download
A USAGE.md View 1 2 1 chunk +81 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
vsm
5 years, 6 months ago (2015-05-28 17:35:17 UTC) #2
Leaf
lgtm with typo fix. https://codereview.chromium.org/1157093004/diff/1/USAGE.md File USAGE.md (right): https://codereview.chromium.org/1157093004/diff/1/USAGE.md#newcode54 USAGE.md:54: DDC output may be testing ...
5 years, 6 months ago (2015-05-28 18:27:25 UTC) #3
vsm
Fix typo
5 years, 6 months ago (2015-05-28 18:28:52 UTC) #4
vsm
https://codereview.chromium.org/1157093004/diff/1/USAGE.md File USAGE.md (right): https://codereview.chromium.org/1157093004/diff/1/USAGE.md#newcode54 USAGE.md:54: DDC output may be testing most easily in [Chrome ...
5 years, 6 months ago (2015-05-28 18:29:27 UTC) #5
Jennifer Messerly
lgtm. I guess you already fixed one of them :) https://codereview.chromium.org/1157093004/diff/1/USAGE.md File USAGE.md (right): https://codereview.chromium.org/1157093004/diff/1/USAGE.md#newcode39 ...
5 years, 6 months ago (2015-05-28 19:26:50 UTC) #6
vsm
https://codereview.chromium.org/1157093004/diff/1/USAGE.md File USAGE.md (right): https://codereview.chromium.org/1157093004/diff/1/USAGE.md#newcode39 USAGE.md:39: will display a severe error. Modifying ```42``` to ```'42'``` ...
5 years, 6 months ago (2015-05-29 13:02:52 UTC) #7
vsm
5 years, 6 months ago (2015-05-29 13:04:46 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
c37fea0d51dd34d3aa5283ac3a3caffc5b65c3c8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698