Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1157033006: DO NOT COMMIT - fn port to RenderNode, work in progress, does not work (Closed)

Created:
5 years, 7 months ago by Hixie
Modified:
5 years, 7 months ago
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

[Effen] port fn and stock to RenderNode, part 1 of many This gets things off the ground barely enough to show some pixels. These are not pixels that are actually part of the stock app, but it's a start. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/23d29ac7a04986af85d8f0d0c6a767795bba3f90

Patch Set 1 #

Patch Set 2 : split out components2/ fork #

Patch Set 3 : merge the setBoxDecoration()/decoration= change #

Patch Set 4 : merge in further setBoxDecoration() changes #

Patch Set 5 : further changes extracted into other CLs #

Patch Set 6 : split app.dart changes #

Patch Set 7 : split out making some fn members public #

Patch Set 8 : split out _syncChild() changes #

Patch Set 9 : merge in layout2 changes #

Patch Set 10 : fix bugs around making things dirty so it actually renders #

Patch Set 11 : fix adam's review comments #

Patch Set 12 : fix adam's review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+383 lines, -218 lines) Patch
M sky/examples/stocks2/lib/stock_app.dart View 1 3 chunks +41 lines, -38 lines 0 comments Download
M sky/examples/stocks2/lib/stock_data.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/BUILD.gn View 2 chunks +24 lines, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/scaffold.dart View 1 2 3 4 5 6 7 8 9 1 chunk +207 lines, -44 lines 0 comments Download
M sky/sdk/lib/framework/fn2.dart View 1 2 3 4 5 6 7 27 chunks +99 lines, -94 lines 0 comments Download
M sky/sdk/lib/framework/layout2.dart View 1 2 3 4 5 6 7 8 9 3 chunks +7 lines, -3 lines 0 comments Download
D sky/sdk/lib/framework/layouts/block.dart View 1 chunk +0 lines, -30 lines 0 comments Download
M sky/sdk/lib/framework/node.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/shell/ui/engine.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
eseidel
I would break this down into 2 commits. One which forks and a second which ...
5 years, 7 months ago (2015-05-27 06:00:59 UTC) #2
Hixie
On 2015/05/27 at 06:00:59, eseidel wrote: > I would break this down into 2 commits. ...
5 years, 7 months ago (2015-05-27 15:40:07 UTC) #3
abarth-chromium
lgtm
5 years, 7 months ago (2015-05-27 20:28:56 UTC) #5
Hixie
5 years, 7 months ago (2015-05-27 20:36:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #12 (id:160002) manually as
23d29ac7a04986af85d8f0d0c6a767795bba3f90 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698