Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Side by Side Diff: pkg/unittest/lib/src/config.dart

Issue 11570065: Close receivePort when tests are failing. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | utils/tests/pub/pub.status » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of unittest; 5 part of unittest;
6 6
7 /** 7 /**
8 * Hooks to configure the unittest library for different platforms. This class 8 * Hooks to configure the unittest library for different platforms. This class
9 * implements the API in a platform-independent way. Tests that want to take 9 * implements the API in a platform-independent way. Tests that want to take
10 * advantage of the platform can create a subclass and override methods from 10 * advantage of the platform can create a subclass and override methods from
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 } else if (failed == 0 && errors == 0 && uncaughtError == null) { 122 } else if (failed == 0 && errors == 0 && uncaughtError == null) {
123 print('All $passed tests passed.'); 123 print('All $passed tests passed.');
124 success = true; 124 success = true;
125 } else { 125 } else {
126 if (uncaughtError != null) { 126 if (uncaughtError != null) {
127 print('Top-level uncaught error: $uncaughtError'); 127 print('Top-level uncaught error: $uncaughtError');
128 } 128 }
129 print('$passed PASSED, $failed FAILED, $errors ERRORS'); 129 print('$passed PASSED, $failed FAILED, $errors ERRORS');
130 } 130 }
131 131
132 _receivePort.close();
132 if (success) { 133 if (success) {
133 _postMessage('unittest-suite-success'); 134 _postMessage('unittest-suite-success');
134 _receivePort.close();
135 } else { 135 } else {
136 throw new Exception('Some tests failed.'); 136 throw new Exception('Some tests failed.');
137 } 137 }
138 } 138 }
139 139
140 String _indent(String str) { 140 String _indent(String str) {
141 // TODO(nweiz): Use this simpler code once issue 2980 is fixed. 141 // TODO(nweiz): Use this simpler code once issue 2980 is fixed.
142 // return str.replaceAll(new RegExp("^", multiLine: true), " "); 142 // return str.replaceAll(new RegExp("^", multiLine: true), " ");
143 143
144 return Strings.join(str.split("\n").map((line) => " $line"), "\n"); 144 return Strings.join(str.split("\n").map((line) => " $line"), "\n");
145 } 145 }
146 146
147 /** Handle errors that happen outside the tests. */ 147 /** Handle errors that happen outside the tests. */
148 // TODO(vsm): figure out how to expose the stack trace here 148 // TODO(vsm): figure out how to expose the stack trace here
149 // Currently e.message works in dartium, but not in dartc. 149 // Currently e.message works in dartium, but not in dartc.
150 handleExternalError(e, String message) => 150 handleExternalError(e, String message) =>
151 _reportTestError('$message\nCaught $e', ''); 151 _reportTestError('$message\nCaught $e', '');
152 152
153 _postMessage(String message) { 153 _postMessage(String message) {
154 // In dart2js browser tests, the JavaScript-based test controller 154 // In dart2js browser tests, the JavaScript-based test controller
155 // intercepts calls to print and listens for "secret" messages. 155 // intercepts calls to print and listens for "secret" messages.
156 print(message); 156 print(message);
157 } 157 }
158 } 158 }
OLDNEW
« no previous file with comments | « no previous file | utils/tests/pub/pub.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698