Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11570038: Remove IPC::MessageIterator. (Closed)

Created:
8 years ago by viettrungluu
Modified:
8 years ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Remove IPC::MessageIterator. It's a rarely-used and completely unnecessary (and thin) wrapper around PickleIterator. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173525

Patch Set 1 #

Total comments: 2

Patch Set 2 : oops #

Patch Set 3 : fix win #

Patch Set 4 : . #

Total comments: 1

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -59 lines) Patch
M content/browser/loader/resource_dispatcher_host_unittest.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M content/common/indexed_db/indexed_db_message_filter.cc View 2 chunks +4 lines, -1 line 0 comments Download
M ipc/ipc_channel_win.cc View 1 2 3 4 2 chunks +13 lines, -5 lines 0 comments Download
M ipc/ipc_message_utils.h View 2 chunks +1 line, -14 lines 0 comments Download
M ipc/ipc_message_utils.cc View 1 1 chunk +0 lines, -17 lines 0 comments Download
M ipc/ipc_tests.cc View 5 chunks +28 lines, -19 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
viettrungluu
8 years ago (2012-12-14 21:57:05 UTC) #1
jam
lgtm with comment addressed https://codereview.chromium.org/11570038/diff/1/ipc/ipc_message_utils.cc File ipc/ipc_message_utils.cc (right): https://codereview.chromium.org/11570038/diff/1/ipc/ipc_message_utils.cc#newcode259 ipc/ipc_message_utils.cc:259: #if 0 did you mean ...
8 years ago (2012-12-14 23:00:28 UTC) #2
viettrungluu
Thanks. https://codereview.chromium.org/11570038/diff/1/ipc/ipc_message_utils.cc File ipc/ipc_message_utils.cc (right): https://codereview.chromium.org/11570038/diff/1/ipc/ipc_message_utils.cc#newcode259 ipc/ipc_message_utils.cc:259: #if 0 On 2012/12/14 23:00:28, John Abd-El-Malek wrote: ...
8 years ago (2012-12-14 23:05:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/11570038/4002
8 years ago (2012-12-14 23:09:44 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years ago (2012-12-15 00:08:44 UTC) #5
viettrungluu
Argh, was broken on Windows. PTAL.
8 years ago (2012-12-15 01:04:53 UTC) #6
jam
https://codereview.chromium.org/11570038/diff/7005/ipc/ipc_channel_win.cc File ipc/ipc_channel_win.cc (right): https://codereview.chromium.org/11570038/diff/7005/ipc/ipc_channel_win.cc#newcode170 ipc/ipc_channel_win.cc:170: NOTREACHED(); seems unfortunate to duplicate this little block twice. ...
8 years ago (2012-12-17 16:21:57 UTC) #7
viettrungluu
On 2012/12/17 16:21:57, John Abd-El-Malek wrote: > https://codereview.chromium.org/11570038/diff/7005/ipc/ipc_channel_win.cc > File ipc/ipc_channel_win.cc (right): > > https://codereview.chromium.org/11570038/diff/7005/ipc/ipc_channel_win.cc#newcode170 ...
8 years ago (2012-12-17 17:31:46 UTC) #8
jam
lgtm
8 years ago (2012-12-17 17:52:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/11570038/19001
8 years ago (2012-12-17 18:12:44 UTC) #10
commit-bot: I haz the power
8 years ago (2012-12-17 20:23:49 UTC) #11
Message was sent while issue was closed. 
Change committed as 173525

Powered by Google App Engine
This is Rietveld 408576698