Issue 11570036: Add some traces for when render pass caching fails

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11570036: Add some traces for when render pass caching fails (Closed)

Created:
8 years ago by jamesr

Modified:
8 years ago

Reviewers:
danakj, enne (OOO)

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add some traces for when render pass caching fails This makes it easier to diagnose when caches are hitting or missing (and why) in traces. It's fairly verbose, but I've been patching it in locally for long enough that it seems generally useful. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173359

Patch Set 1 #

Total comments: 1

Patch Set 2 : early out #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -4 lines)			Patch
	M	cc/layer_tree_host_common.cc	View		2 chunks	+9 lines, -3 lines	0 comments	Download
	M	cc/layer_tree_host_impl.cc	View	1	1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

danakj

https://codereview.chromium.org/11570036/diff/1/cc/layer_tree_host_impl.cc File cc/layer_tree_host_impl.cc (right): https://codereview.chromium.org/11570036/diff/1/cc/layer_tree_host_impl.cc#newcode705 cc/layer_tree_host_impl.cc:705: TRACE_EVENT0("cc", "CullRenderPassesWithCachedTextures have damage"); we could also early-out and ...

8 years ago (2012-12-14 23:21:13 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/11570036/5001

8 years ago (2012-12-16 02:13:02 UTC) #4

Message was sent while issue was closed.

Change committed as 173359

Expand Messages | Collapse Messages