Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: net/base/cert_verify_proc_android.cc

Issue 11570019: Fix a glitch in disentanglement of CertVerifyProc(OpenSSL/Android) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: address Ryan's remarks Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/cert_verify_proc_android.cc
diff --git a/net/base/cert_verify_proc_android.cc b/net/base/cert_verify_proc_android.cc
index 1bdbcef87b22eb71937be686f02be26d6d194943..a7b17e6b387733d15e3f40d35554e280ee48beea 100644
--- a/net/base/cert_verify_proc_android.cc
+++ b/net/base/cert_verify_proc_android.cc
@@ -88,6 +88,16 @@ int CertVerifyProcAndroid::VerifyInternal(X509Certificate* cert,
if (IsCertStatusError(verify_result->cert_status))
return MapCertStatusToNetError(verify_result->cert_status);
+ // TODO(ppi): Implement missing functionality: yielding the constructed trust
+ // chain, public key hashes of its certificates and |is_issued_by_known_root|
+ // flag. All of the above require specific support from the platform, missing
+ // in the Java APIs. See also: http://crbug.com/116838
+
+ // Until the required support is available in the platform, we don't know if
+ // the trust root at the end of the chain was standard or user-added, so we
+ // mark all correctly verified certificates as issued by a known root.
+ verify_result->is_issued_by_known_root = true;
+
return OK;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698