chrome/chrome_browser.gypi - Issue 11570009: Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 11570009: Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments, use pure builder pattern. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_ui_prefs.cc ('K') | « chrome/browser/web_resource/promo_resource_service.cc ('k') | chrome/test/base/testing_browser_process.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 2cad0fc73351c4d2c620f39a8550715fe72b890a..0a8746af9ee025ab200fe9840bd185bb7cdf0922 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -1465,8 +1465,8 @@

'browser/preferences_mac.h',

'browser/prefs/browser_prefs.cc',

'browser/prefs/browser_prefs.h',

- 'browser/prefs/chrome_pref_service_builder.cc',

- 'browser/prefs/chrome_pref_service_builder.h',

+ 'browser/prefs/chrome_pref_service_factory.cc',

+ 'browser/prefs/chrome_pref_service_factory.h',

'browser/prefs/command_line_pref_store.cc',

'browser/prefs/command_line_pref_store.h',

'browser/prefs/incognito_mode_prefs.cc',

@@ -1480,6 +1480,12 @@

'browser/prefs/pref_service_builder.cc',

'browser/prefs/pref_service_builder.h',

'browser/prefs/pref_service_observer.h',

+ 'browser/prefs/pref_service_simple.cc',

+ 'browser/prefs/pref_service_simple.h',

+ 'browser/prefs/pref_service_syncable.cc',

+ 'browser/prefs/pref_service_syncable.h',

+ 'browser/prefs/pref_service_syncable_builder.cc',

+ 'browser/prefs/pref_service_syncable_builder.h',

'browser/prefs/pref_value_store.cc',

'browser/prefs/pref_value_store.h',

'browser/prefs/proxy_config_dictionary.cc',

« chrome/browser/ui/browser_ui_prefs.cc ('K') | « chrome/browser/web_resource/promo_resource_service.cc ('k') | chrome/test/base/testing_browser_process.h » ('j') | no next file with comments »