chrome/browser/web_resource/promo_resource_service.h - Issue 11570009: Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/web_resource/promo_resource_service.h

Issue 11570009: Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments, use pure builder pattern. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_ui_prefs.cc ('K') | « chrome/browser/web_resource/plugins_resource_service.cc ('k') | chrome/browser/web_resource/promo_resource_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/web_resource/promo_resource_service.h

diff --git a/chrome/browser/web_resource/promo_resource_service.h b/chrome/browser/web_resource/promo_resource_service.h

index fa4668b8c35b0171d445ee62a3d07c0a1f693703..e55e59a0ac478b99b5f1aa4340ab5051129b41c1 100644

--- a/chrome/browser/web_resource/promo_resource_service.h

+++ b/chrome/browser/web_resource/promo_resource_service.h

@@ -15,7 +15,8 @@ class DictionaryValue;

}

class NotificationPromo;

-class PrefService;

+class PrefServiceSimple;

+class PrefServiceSyncable;

class Profile;

// A PromoResourceService fetches data from a web resource server to be used to

@@ -24,9 +25,9 @@ class Profile;

// promotional messages to certain groups of Chrome users.

class PromoResourceService : public WebResourceService {

public:

- static void RegisterPrefs(PrefService* local_state);

+ static void RegisterPrefs(PrefServiceSimple* local_state);

- static void RegisterUserPrefs(PrefService* prefs);

+ static void RegisterUserPrefs(PrefServiceSyncable* prefs);

explicit PromoResourceService(Profile* profile);