chrome/browser/signin/signin_manager_unittest.cc - Issue 11570009: Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/signin_manager_unittest.cc

Issue 11570009: Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments, use pure builder pattern. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/prefs/pref_service_simple.cc ('K') | « chrome/browser/signin/signin_manager_factory.cc ('k') | chrome/browser/speech/chrome_speech_recognition_preferences.h » ('j') | chrome/browser/ui/browser_ui_prefs.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/signin/signin_manager_unittest.cc

diff --git a/chrome/browser/signin/signin_manager_unittest.cc b/chrome/browser/signin/signin_manager_unittest.cc

index 638d5316a1bc096ce3f78f3d52607a7083efc87c..cc8e974b6232994bd6454c396dda1ece10ffcbff 100644

--- a/chrome/browser/signin/signin_manager_unittest.cc

+++ b/chrome/browser/signin/signin_manager_unittest.cc

@@ -45,7 +45,7 @@ const char kGetTokenPairValidResponse[] =

class SigninManagerTest : public TokenServiceTestHarness {

public:

virtual void SetUp() OVERRIDE {

- prefs_.reset(new TestingPrefService);

+ prefs_.reset(new TestingPrefServiceSimple);

chrome::RegisterLocalState(prefs_.get());

static_cast<TestingBrowserProcess*>(g_browser_process)->SetLocalState(

prefs_.get());

@@ -187,7 +187,7 @@ class SigninManagerTest : public TokenServiceTestHarness {

scoped_ptr<SigninManager> manager_;

content::TestNotificationTracker google_login_success_;

content::TestNotificationTracker google_login_failure_;

- scoped_ptr<TestingPrefService> prefs_;

+ scoped_ptr<TestingPrefServiceSimple> prefs_;

};

// NOTE: ClientLogin's "StartSignin" is called after collecting credentials