chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc - Issue 11570009: Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc

Issue 11570009: Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/prefs/pref_service_simple.h ('K') | « chrome/browser/printing/cloud_print/cloud_print_url.cc ('k') | chrome/browser/printing/print_dialog_cloud.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc

diff --git a/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc b/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc

index b88c8fb8d5873ec9b065266b2dfd22067a162ee8..61cb2b88a42966e95729dc3bdff4ae586563abb3 100644

--- a/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc

+++ b/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc

@@ -472,7 +472,7 @@ TEST_F(CloudPrintProxyPolicyStartupTest, StartBrowserWithoutPolicy) {

CloudPrintProxyServiceFactory::GetInstance()->

SetTestingFactory(profile, CloudPrintProxyServiceFactoryForPolicyTest);

- TestingPrefService* prefs = profile->GetTestingPrefService();

+ TestingPrefServiceSyncable* prefs = profile->GetTestingPrefService();

prefs->SetUserPref(prefs::kCloudPrintEmail,

Value::CreateStringValue(

MockServiceIPCServer::EnabledUserId()));

@@ -512,7 +512,7 @@ TEST_F(CloudPrintProxyPolicyStartupTest, StartBrowserWithPolicy) {