Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: chrome/browser/prefs/pref_value_store.h

Issue 11570009: Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/pref_value_store.h
diff --git a/chrome/browser/prefs/pref_value_store.h b/chrome/browser/prefs/pref_value_store.h
index 4c027a5898196a50a8900fc218a86736306da839..47fb58e4fbcc55ad346839f510b9d28794283a4e 100644
--- a/chrome/browser/prefs/pref_value_store.h
+++ b/chrome/browser/prefs/pref_value_store.h
@@ -46,7 +46,6 @@ class PrefValueStore {
PrefStore* user_prefs,
PrefStore* recommended_prefs,
PrefStore* default_prefs,
- PrefModelAssociator* pref_sync_associator,
PrefNotifier* pref_notifier);
virtual ~PrefValueStore();
@@ -58,9 +57,12 @@ class PrefValueStore {
PrefStore* user_prefs,
PrefStore* recommended_prefs,
PrefStore* default_prefs,
- PrefModelAssociator* pref_sync_associator,
PrefNotifier* pref_notifier);
+ // TODO(joi): Remove this completely; the part PrefModelAssociator
+ // needs can be handled simply as a PrefObserver.
+ void set_sync_associator(PrefModelAssociator* sync_associator);
+
// Gets the value for the given preference name that has the specified value
// type. Values stored in a PrefStore that have the matching |name| but
// a non-matching |type| are silently skipped. Returns true if a valid value

Powered by Google App Engine
This is Rietveld 408576698