chrome/browser/ui/webui/ntp/new_tab_page_handler.h - Issue 11570009: Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/new_tab_page_handler.h

Issue 11570009: Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ready for review. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/browser_actions_container.cc ('K') | « chrome/browser/ui/webui/ntp/most_visited_handler.cc ('k') | chrome/browser/ui/webui/ntp/new_tab_page_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/ntp/new_tab_page_handler.h

diff --git a/chrome/browser/ui/webui/ntp/new_tab_page_handler.h b/chrome/browser/ui/webui/ntp/new_tab_page_handler.h

index 2a580105f5b22f7ac0b3abc787aa9f8fd6cad302..5e25fed35437c3ffad2ef2e72bb0be3510d2f3b3 100644

--- a/chrome/browser/ui/webui/ntp/new_tab_page_handler.h

+++ b/chrome/browser/ui/webui/ntp/new_tab_page_handler.h

@@ -9,7 +9,8 @@

#include "chrome/common/chrome_notification_types.h"

#include "content/public/browser/web_ui_message_handler.h"

-class PrefService;

+class PrefServiceSimple;

+class PrefServiceSyncable;

class Profile;

// Handler for general New Tab Page functionality that does not belong in a

@@ -19,10 +20,10 @@ class NewTabPageHandler : public content::WebUIMessageHandler {

NewTabPageHandler();

// Register NTP per-profile preferences.

- static void RegisterUserPrefs(PrefService* prefs);

+ static void RegisterUserPrefs(PrefServiceSyncable* prefs);

// Register NTP profile-independent preferences.

- static void RegisterPrefs(PrefService* prefs);

+ static void RegisterPrefs(PrefServiceSimple* prefs);

Mattias Nissler (ping if slow) 2012/12/20 13:41:52 dead code?

Jói 2012/12/20 16:30:31 I think so, removed.

// Registers values (strings etc.) for the page.

static void GetLocalizedValues(Profile* profile, DictionaryValue* values);