Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable.

chrome/browser/prefs/pref_service_builder.cc

Index: chrome/browser/prefs/pref_service_builder.cc
diff --git a/chrome/browser/prefs/pref_service_builder.cc b/chrome/browser/prefs/pref_service_builder.cc
index daa1fd3c5dbf6b009ccf98ee69fea5ddacb9b113..a254c7e9fc72295ce25e87528c29ef88e4649816 100644
--- a/chrome/browser/prefs/pref_service_builder.cc
+++ b/chrome/browser/prefs/pref_service_builder.cc
@@ -17,15 +17,9 @@ namespace {
 void DoNothingHandleReadError(PersistentPrefStore::PrefReadError error) {
 }
 
-// Dummy default implementation.
-std::string DummyGetLocalizedString(int id) {
-  return "";
-}
-
 }  // namespace
 
-PrefServiceBuilder::PrefServiceBuilder()
-    : sync_associator_(NULL) {
+PrefServiceBuilder::PrefServiceBuilder() {
   ResetDefaultState();
 }
 
@@ -58,18 +52,6 @@ PrefServiceBuilder& PrefServiceBuilder::WithRecommendedPrefs(PrefStore* store) {
   return *this;
 }
 
-PrefServiceBuilder& PrefServiceBuilder::WithSyncAssociator(
-    PrefModelAssociator* associator) {
-  sync_associator_ = associator;
-  return *this;
-}
-
-PrefServiceBuilder& PrefServiceBuilder::WithLocalizedStringMethod(
-    const base::Callback<std::string(int)>& localized_string_method) {
-  get_localized_string_method_ = localized_string_method;
-  return *this;
-}
-
 PrefServiceBuilder& PrefServiceBuilder::WithReadErrorCallback(
     const base::Callback<void(PersistentPrefStore::PrefReadError)>&
     read_error_callback) {
@@ -89,40 +71,33 @@ PrefServiceBuilder& PrefServiceBuilder::WithAsync(bool async) {
   return *this;
 }
 
-PrefService* PrefServiceBuilder::Create() {
+PrefService* PrefServiceBuilder::Build(PrefService* pref_service) {
   DefaultPrefStore* default_pref_store = new DefaultPrefStore();
   PrefNotifierImpl* pref_notifier = new PrefNotifierImpl();
-  PrefService* pref_service =
-      new PrefService(
-          pref_notifier,
-          new PrefValueStore(
-              managed_prefs_.get(),
-              extension_prefs_.get(),
-              command_line_prefs_.get(),
-              user_prefs_.get(),
-              recommended_prefs_.get(),
-              default_pref_store,
-              sync_associator_,
-              pref_notifier),
+  pref_service->Initialize(
+      pref_notifier,
+      new PrefValueStore(
+          managed_prefs_.get(),
+          extension_prefs_.get(),
+          command_line_prefs_.get(),
           user_prefs_.get(),
+          recommended_prefs_.get(),
           default_pref_store,
-          sync_associator_,
-          get_localized_string_method_,
-          read_error_callback_,
-          async_);
-  managed_prefs_ = NULL;
-  extension_prefs_ = NULL;
-  command_line_prefs_ = NULL;
-  user_prefs_ = NULL;
-  recommended_prefs_ = NULL;
-  sync_associator_ = NULL;
+          pref_notifier),
+      user_prefs_.get(),
+      default_pref_store,
+      read_error_callback_,
+      async_);
   ResetDefaultState();
-
   return pref_service;
 }
 
 void PrefServiceBuilder::ResetDefaultState() {
-  get_localized_string_method_ = base::Bind(&DummyGetLocalizedString);
+  managed_prefs_ = NULL;
+  extension_prefs_ = NULL;
+  command_line_prefs_ = NULL;
+  user_prefs_ = NULL;
+  recommended_prefs_ = NULL;
   read_error_callback_ = base::Bind(&DoNothingHandleReadError);
   async_ = false;
 }