Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1601)

Unified Diff: chrome/browser/extensions/api/tabs/tabs.cc

Issue 11570009: Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ready for review. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/tabs/tabs.cc
diff --git a/chrome/browser/extensions/api/tabs/tabs.cc b/chrome/browser/extensions/api/tabs/tabs.cc
index b7871dc3e1b62edc724347bacea4754ed58b50ef..5f26438377f359aa6ef95c1cca1cebec070537c7 100644
--- a/chrome/browser/extensions/api/tabs/tabs.cc
+++ b/chrome/browser/extensions/api/tabs/tabs.cc
@@ -1639,7 +1639,7 @@ bool CaptureVisibleTabFunction::GetTabToCapture(WebContents** web_contents) {
};
bool CaptureVisibleTabFunction::RunImpl() {
- PrefService* service = profile()->GetPrefs();
+ PrefServiceSyncable* service = profile()->GetPrefs();
Mattias Nissler (ping if slow) 2012/12/19 19:50:22 Can we use PrefServiceBase here?
Jói 2012/12/20 16:30:31 Done.
if (service->GetBoolean(prefs::kDisableScreenshots)) {
error_ = keys::kScreenshotsDisabled;
return false;
@@ -1800,9 +1800,10 @@ void CaptureVisibleTabFunction::SendResultFromBitmap(
SendResponse(true);
}
-void CaptureVisibleTabFunction::RegisterUserPrefs(PrefService* service) {
+void CaptureVisibleTabFunction::RegisterUserPrefs(
+ PrefServiceSyncable* service) {
service->RegisterBooleanPref(prefs::kDisableScreenshots, false,
- PrefService::UNSYNCABLE_PREF);
+ PrefServiceSyncable::UNSYNCABLE_PREF);
}
bool DetectTabLanguageFunction::RunImpl() {

Powered by Google App Engine
This is Rietveld 408576698