Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: chrome/browser/download/chrome_download_manager_delegate_unittest.cc

Issue 11570009: Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/file_path.h" 5 #include "base/file_path.h"
6 #include "base/file_util.h" 6 #include "base/file_util.h"
7 #include "base/files/scoped_temp_dir.h" 7 #include "base/files/scoped_temp_dir.h"
8 #include "base/message_loop.h" 8 #include "base/message_loop.h"
9 #include "base/observer_list.h" 9 #include "base/observer_list.h"
10 #include "base/stl_util.h" 10 #include "base/stl_util.h"
(...skipping 261 matching lines...) Expand 10 before | Expand all | Expand 10 after
272 272
273 private: 273 private:
274 // Verifies that |target_path|, |disposition|, |danger_type| and 274 // Verifies that |target_path|, |disposition|, |danger_type| and
275 // |intermediate_path| matches the expectations of |test_case|. 275 // |intermediate_path| matches the expectations of |test_case|.
276 void DownloadTargetVerifier(const DownloadTestCase* test_case, 276 void DownloadTargetVerifier(const DownloadTestCase* test_case,
277 const FilePath& target_path, 277 const FilePath& target_path,
278 DownloadItem::TargetDisposition disposition, 278 DownloadItem::TargetDisposition disposition,
279 content::DownloadDangerType danger_type, 279 content::DownloadDangerType danger_type,
280 const FilePath& intermediate_path); 280 const FilePath& intermediate_path);
281 281
282 TestingPrefService* pref_service_; 282 TestingPrefServiceSyncable* pref_service_;
283 base::ScopedTempDir test_download_dir_; 283 base::ScopedTempDir test_download_dir_;
284 content::TestBrowserThread ui_thread_; 284 content::TestBrowserThread ui_thread_;
285 content::TestBrowserThread file_thread_; 285 content::TestBrowserThread file_thread_;
286 scoped_refptr<content::MockDownloadManager> download_manager_; 286 scoped_refptr<content::MockDownloadManager> download_manager_;
287 scoped_refptr<TestChromeDownloadManagerDelegate> delegate_; 287 scoped_refptr<TestChromeDownloadManagerDelegate> delegate_;
288 MockWebContentsDelegate web_contents_delegate_; 288 MockWebContentsDelegate web_contents_delegate_;
289 }; 289 };
290 290
291 ChromeDownloadManagerDelegateTest::ChromeDownloadManagerDelegateTest() 291 ChromeDownloadManagerDelegateTest::ChromeDownloadManagerDelegateTest()
292 : ChromeRenderViewHostTestHarness(), 292 : ChromeRenderViewHostTestHarness(),
(...skipping 619 matching lines...) Expand 10 before | Expand all | Expand 10 after
912 // Run the first test case again. Since the last download path was cleared, 912 // Run the first test case again. Since the last download path was cleared,
913 // this test case should behave identically to the first time it was run. 913 // this test case should behave identically to the first time it was run.
914 RunTestCases(kLastSavePathTestCases, 1); 914 RunTestCases(kLastSavePathTestCases, 1);
915 } 915 }
916 916
917 // TODO(asanka): Add more tests. 917 // TODO(asanka): Add more tests.
918 // * Default download path is not writable. 918 // * Default download path is not writable.
919 // * Download path doesn't exist. 919 // * Download path doesn't exist.
920 // * IsDangerousFile(). 920 // * IsDangerousFile().
921 // * Filename generation. 921 // * Filename generation.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698