Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable.

base/prefs/public/pref_service_base.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This is the base interface for a preference services that provides
 // a way to access the application's current preferences.
 //
 // This base interface assumes all preferences are local.  See
 // SyncablePrefServiceBase for the interface to a preference service
 // that stores preferences that can be synced.
@@ skipping 18 matching lines @@
 class FilePath;
 class PrefObserver;
 
 class PrefServiceBase {
  public:
   // Retrieves a PrefServiceBase for the given context.
   static PrefServiceBase* FromBrowserContext(content::BrowserContext* context);
 
   virtual ~PrefServiceBase() {}
 
-  // Enum used when registering preferences to determine if it should be synced
-  // or not. This is only used for profile prefs, not local state prefs.
-  // See the Register*Pref methods for profile prefs below.
-  enum PrefSyncStatus {
-    UNSYNCABLE_PREF,
-    SYNCABLE_PREF
-  };
-
   // Interface to a single preference.
   class Preference {
    public:
     virtual ~Preference() {}
 
     // Returns the name of the Preference (i.e., the key, e.g.,
     // browser.window_placement).
     virtual const std::string name() const = 0;
 
     // Returns the registered type of the preference.
@@ skipping 48 matching lines @@
   };
 
   // Returns true if the preference for the given preference name is available
   // and is managed.
   virtual bool IsManagedPreference(const char* pref_name) const = 0;
 
   // Returns |true| if a preference with the given name is available and its
   // value can be changed by the user.
   virtual bool IsUserModifiablePreference(const char* pref_name) const = 0;
 
-  // Make the PrefService aware of a pref.
-  // TODO(zea): split local state and profile prefs into their own subclasses.
-  // ---------- Local state prefs  ----------
-  virtual void RegisterBooleanPref(const char* path,
-                                   bool default_value) = 0;
-  virtual void RegisterIntegerPref(const char* path,
-                                   int default_value) = 0;
-  virtual void RegisterDoublePref(const char* path,
-                                  double default_value) = 0;
-  virtual void RegisterStringPref(const char* path,
-                                  const std::string& default_value) = 0;
-  virtual void RegisterFilePathPref(const char* path,
-                                    const FilePath& default_value) = 0;
-  virtual void RegisterListPref(const char* path) = 0;
-  virtual void RegisterDictionaryPref(const char* path) = 0;
-  // These take ownership of the default_value:
-  virtual void RegisterListPref(const char* path,
-                                base::ListValue* default_value) = 0;
-  virtual void RegisterDictionaryPref(
-      const char* path, base::DictionaryValue* default_value) = 0;
-  // These variants use a default value from the locale dll instead.
-  virtual void RegisterLocalizedBooleanPref(
-      const char* path, int locale_default_message_id) = 0;
-  virtual void RegisterLocalizedIntegerPref(
-      const char* path, int locale_default_message_id) = 0;
-  virtual void RegisterLocalizedDoublePref(
-      const char* path, int locale_default_message_id) = 0;
-  virtual void RegisterLocalizedStringPref(
-      const char* path, int locale_default_message_id) = 0;
-  virtual void RegisterInt64Pref(const char* path,
-                                 int64 default_value) = 0;
-
-  //  ---------- Profile prefs  ----------
-  // Profile prefs must specify whether the pref should be synchronized across
-  // machines or not (see PrefSyncStatus enum above).
-  virtual void RegisterBooleanPref(const char* path,
-                                   bool default_value,
-                                   PrefSyncStatus sync_status) = 0;
-  virtual void RegisterIntegerPref(const char* path,
-                                   int default_value,
-                                   PrefSyncStatus sync_status) = 0;
-  virtual void RegisterDoublePref(const char* path,
-                                  double default_value,
-                                  PrefSyncStatus sync_status) = 0;
-  virtual void RegisterStringPref(const char* path,
-                                  const std::string& default_value,
-                                  PrefSyncStatus sync_status) = 0;
-  virtual void RegisterFilePathPref(const char* path,
-                                    const FilePath& default_value,
-                                    PrefSyncStatus sync_status) = 0;
-  virtual void RegisterListPref(const char* path,
-                                PrefSyncStatus sync_status) = 0;
-  virtual void RegisterDictionaryPref(const char* path,
-                                      PrefSyncStatus sync_status) = 0;
-  // These take ownership of the default_value:
-  virtual void RegisterListPref(const char* path,
-                                base::ListValue* default_value,
-                                PrefSyncStatus sync_status) = 0;
-  virtual void RegisterDictionaryPref(const char* path,
-                                      base::DictionaryValue* default_value,
-                                      PrefSyncStatus sync_status) = 0;
-  // These variants use a default value from the locale dll instead.
-  virtual void RegisterLocalizedBooleanPref(
-      const char* path,
-      int locale_default_message_id,
-      PrefSyncStatus sync_status) = 0;
-  virtual void RegisterLocalizedIntegerPref(
-      const char* path,
-      int locale_default_message_id,
-      PrefSyncStatus sync_status) = 0;
-  virtual void RegisterLocalizedDoublePref(
-      const char* path,
-      int locale_default_message_id,
-      PrefSyncStatus sync_status) = 0;
-  virtual void RegisterLocalizedStringPref(
-      const char* path,
-      int locale_default_message_id,
-      PrefSyncStatus sync_status) = 0;
-  virtual void RegisterInt64Pref(const char* path,
-                                 int64 default_value,
-                                 PrefSyncStatus sync_status) = 0;
-  virtual void RegisterUint64Pref(const char* path,
-                                  uint64 default_value,
-                                  PrefSyncStatus sync_status) = 0;
   // Unregisters a preference.
   virtual void UnregisterPreference(const char* path) = 0;
 
   // Look up a preference.  Returns NULL if the preference is not
   // registered.
   virtual const Preference* FindPreference(const char* pref_name) const = 0;
 
   // If the path is valid and the value at the end of the path matches the type
   // specified, it will return the specified value.  Otherwise, the default
   // value (set when the pref was registered) will be returned.
@@ skipping 50 matching lines @@
   //
   // If the pref at the given path changes, we call the observer's
   // OnPreferenceChanged method. Note that observers should not call
   // these methods directly but rather use a PrefChangeRegistrar to
   // make sure the observer gets cleaned up properly.
   virtual void AddPrefObserver(const char* path, PrefObserver* obs) = 0;
   virtual void RemovePrefObserver(const char* path, PrefObserver* obs) = 0;
 };
 
 #endif  // BASE_PREFS_PUBLIC_PREF_SERVICE_BASE_H_