Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Side by Side Diff: chrome/browser/ui/tabs/pinned_tab_codec.cc

Issue 11570009: Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: WIP, latest changes from kaiwang@ Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/tabs/pinned_tab_codec.h" 5 #include "chrome/browser/ui/tabs/pinned_tab_codec.h"
6 6
7 #include "base/values.h" 7 #include "base/values.h"
8 #include "chrome/browser/extensions/tab_helper.h" 8 #include "chrome/browser/extensions/tab_helper.h"
9 #include "chrome/browser/prefs/pref_service.h" 9 #include "chrome/browser/prefs/pref_service.h"
10 #include "chrome/browser/prefs/scoped_user_pref_update.h" 10 #include "chrome/browser/prefs/scoped_user_pref_update.h"
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 return false; 92 return false;
93 tab->url = GURL(url_string); 93 tab->url = GURL(url_string);
94 94
95 if (value.GetString(kAppID, &(tab->app_id))) 95 if (value.GetString(kAppID, &(tab->app_id)))
96 tab->is_app = true; 96 tab->is_app = true;
97 97
98 return true; 98 return true;
99 } 99 }
100 100
101 // static 101 // static
102 void PinnedTabCodec::RegisterUserPrefs(PrefService* prefs) { 102 void PinnedTabCodec::RegisterUserPrefs(PrefServiceSyncable* prefs) {
103 prefs->RegisterListPref(prefs::kPinnedTabs, PrefService::UNSYNCABLE_PREF); 103 prefs->RegisterListPref(prefs::kPinnedTabs,
104 PrefServiceSyncable::UNSYNCABLE_PREF);
104 } 105 }
105 106
106 // static 107 // static
107 void PinnedTabCodec::WritePinnedTabs(Profile* profile) { 108 void PinnedTabCodec::WritePinnedTabs(Profile* profile) {
108 PrefService* prefs = profile->GetPrefs(); 109 PrefService* prefs = profile->GetPrefs();
109 if (!prefs) 110 if (!prefs)
110 return; 111 return;
111 112
112 ListValue values; 113 ListValue values;
113 for (BrowserList::const_iterator i = BrowserList::begin(); 114 for (BrowserList::const_iterator i = BrowserList::begin();
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 for (size_t i = 0, max = tabs_list->GetSize(); i < max; ++i) { 155 for (size_t i = 0, max = tabs_list->GetSize(); i < max; ++i) {
155 const base::DictionaryValue* tab_values = NULL; 156 const base::DictionaryValue* tab_values = NULL;
156 if (tabs_list->GetDictionary(i, &tab_values)) { 157 if (tabs_list->GetDictionary(i, &tab_values)) {
157 StartupTab tab; 158 StartupTab tab;
158 if (DecodeTab(*tab_values, &tab)) 159 if (DecodeTab(*tab_values, &tab))
159 results.push_back(tab); 160 results.push_back(tab);
160 } 161 }
161 } 162 }
162 return results; 163 return results;
163 } 164 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698