Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable.

chrome/browser/first_run/first_run.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/first_run/first_run.h"
 
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/file_util.h"
 #include "base/metrics/histogram.h"
@@ skipping 493 matching lines @@
     return false;
   return file_util::WriteFile(first_run_sentinel, "", 0) != -1;
 }
 
 std::string GetPingDelayPrefName() {
   return base::StringPrintf("%s.%s",
                             installer::master_preferences::kDistroDict,
                             installer::master_preferences::kDistroPingDelay);
 }
 
-void RegisterUserPrefs(PrefService* prefs) {
+void RegisterUserPrefs(PrefServiceSyncable* prefs) {
   prefs->RegisterIntegerPref(GetPingDelayPrefName().c_str(),
                              0,
-                             PrefService::UNSYNCABLE_PREF);
+                             PrefServiceSyncable::UNSYNCABLE_PREF);
 }
 
 bool RemoveSentinel() {
   FilePath first_run_sentinel;
   if (!internal::GetFirstRunSentinelFilePath(&first_run_sentinel))
     return false;
   return file_util::Delete(first_run_sentinel, false);
 }
 
 bool SetShowFirstRunBubblePref(bool show_bubble) {
   PrefService* local_state = g_browser_process->local_state();
   if (!local_state)
     return false;
   local_state->SetBoolean(prefs::kShouldShowFirstRunBubble, show_bubble);
   return true;
 }
 
 bool SetShowWelcomePagePref() {
-  PrefService* local_state = g_browser_process->local_state();
+  PrefServiceSimple* local_state = g_browser_process->local_state();
   if (!local_state)
     return false;
   if (!local_state->FindPreference(prefs::kShouldShowWelcomePage)) {
     local_state->RegisterBooleanPref(prefs::kShouldShowWelcomePage, false);

[Mattias Nissler (ping if slow), 2012/12/19 19:50:22]

random note: this should happen via browser_prefs::RegisterLocalState()

[Jói, 2012/12/20 16:30:31]

Added TODO.

     local_state->SetBoolean(prefs::kShouldShowWelcomePage, true);
   }
   return true;
 }
 
 bool SetPersonalDataManagerFirstRunPref() {
-  PrefService* local_state = g_browser_process->local_state();
+  PrefServiceSimple* local_state = g_browser_process->local_state();
   if (!local_state)
     return false;
   if (!local_state->FindPreference(
           prefs::kAutofillPersonalDataManagerFirstRun)) {
     local_state->RegisterBooleanPref(

[Mattias Nissler (ping if slow), 2012/12/19 19:50:22]

same here.

[Jói, 2012/12/20 16:30:31]

Added TODO.

         prefs::kAutofillPersonalDataManagerFirstRun, false);
     local_state->SetBoolean(prefs::kAutofillPersonalDataManagerFirstRun, true);
   }
   return true;
 }
 
 void LogFirstRunMetric(FirstRunBubbleMetric metric) {
   UMA_HISTOGRAM_ENUMERATION("FirstRun.SearchEngineBubble", metric,
                             NUM_FIRST_RUN_BUBBLE_METRICS);
 }
@@ skipping 120 matching lines @@
     return SKIP_FIRST_RUN;
 
   internal::SetShowWelcomePagePrefIfNeeded(install_prefs.get());
   internal::SetImportPreferencesAndLaunchImport(out_prefs, install_prefs.get());
   internal::SetDefaultBrowser(install_prefs.get());
 
   return SKIP_FIRST_RUN;
 }
 
 }  // namespace first_run