Split PrefService into PrefService, PrefServiceSimple and PrefServiceSyncable.

chrome/browser/download/chrome_download_manager_delegate_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/message_loop.h"
 #include "base/observer_list.h"
 #include "base/stl_util.h"
@@ skipping 261 matching lines @@
 
  private:
   // Verifies that |target_path|, |disposition|, |danger_type| and
   // |intermediate_path| matches the expectations of |test_case|.
   void DownloadTargetVerifier(const DownloadTestCase* test_case,
                               const FilePath& target_path,
                               DownloadItem::TargetDisposition disposition,
                               content::DownloadDangerType danger_type,
                               const FilePath& intermediate_path);
 
-  TestingPrefService* pref_service_;
+  TestingPrefServiceSyncable* pref_service_;
   base::ScopedTempDir test_download_dir_;
   content::TestBrowserThread ui_thread_;
   content::TestBrowserThread file_thread_;
   scoped_refptr<content::MockDownloadManager> download_manager_;
   scoped_refptr<TestChromeDownloadManagerDelegate> delegate_;
   MockWebContentsDelegate web_contents_delegate_;
 };
 
 ChromeDownloadManagerDelegateTest::ChromeDownloadManagerDelegateTest()
     : ChromeRenderViewHostTestHarness(),
       ui_thread_(content::BrowserThread::UI, &message_loop_),
       file_thread_(content::BrowserThread::FILE, &message_loop_),
       download_manager_(new content::MockDownloadManager) {
   EXPECT_CALL(*download_manager_, GetAllDownloads(_)).WillRepeatedly(Return());
   EXPECT_CALL(*download_manager_, AddObserver(_)).WillRepeatedly(Return());
   EXPECT_CALL(*download_manager_, RemoveObserver(_)).WillRepeatedly(Return());
 }
 
 void ChromeDownloadManagerDelegateTest::SetUp() {
   ChromeRenderViewHostTestHarness::SetUp();
 
   CHECK(profile());
   delegate_ = new TestChromeDownloadManagerDelegate(profile());
   EXPECT_CALL(*download_manager_.get(), GetAllDownloads(_))
       .WillRepeatedly(Return());
   EXPECT_CALL(*download_manager_.get(), AddObserver(_))
       .WillRepeatedly(Return());
   delegate_->SetDownloadManager(download_manager_.get());
   pref_service_ = profile()->GetTestingPrefService();

[Mattias Nissler (ping if slow), 2012/12/19 19:50:22]

used?

[Jói, 2012/12/20 16:30:31]

Yes, from SetDefaultDownloadPath, SetManagedDownloadPath and
SetPromptForDownload, around line 475.

   web_contents()->SetDelegate(&web_contents_delegate_);
 
   ASSERT_TRUE(test_download_dir_.CreateUniqueTempDir());
   SetDefaultDownloadPath(test_download_dir_.path());
 }
 
 void ChromeDownloadManagerDelegateTest::TearDown() {
   message_loop_.RunUntilIdle();
   delegate_->Shutdown();
   ChromeRenderViewHostTestHarness::TearDown();
@@ skipping 590 matching lines @@
   // Run the first test case again. Since the last download path was cleared,
   // this test case should behave identically to the first time it was run.
   RunTestCases(kLastSavePathTestCases, 1);
 }
 
 // TODO(asanka): Add more tests.
 // * Default download path is not writable.
 // * Download path doesn't exist.
 // * IsDangerousFile().
 // * Filename generation.