Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: runtime/bin/extensions_win.cc

Issue 11570006: Revert last unicode change. Causes Pub issues. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/bin/process_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "bin/extensions.h" 5 #include "bin/extensions.h"
6 #include "bin/utils.h"
7 6
8 void* Extensions::LoadExtensionLibrary(const char* library_path, 7 void* Extensions::LoadExtensionLibrary(const char* library_path,
9 const char* extension_name) { 8 const char* extension_name) {
10 const char* strings[] = { library_path, "/", extension_name, ".dll", NULL }; 9 const char* strings[] = { library_path, "/", extension_name, ".dll", NULL };
11 char* library_file = Concatenate(strings); 10 char* library_file = Concatenate(strings);
12 wchar_t* unicode_library_file = StringUtils::Utf8ToWide(library_file); 11 void* lib_handle = LoadLibrary(library_file);
13 void* lib_handle = LoadLibraryW(unicode_library_file);
14 delete(unicode_library_file);
15 free(library_file); 12 free(library_file);
16 return lib_handle; 13 return lib_handle;
17 } 14 }
18 15
19 void* Extensions::ResolveSymbol(void* lib_handle, const char* symbol) { 16 void* Extensions::ResolveSymbol(void* lib_handle, const char* symbol) {
20 return GetProcAddress(reinterpret_cast<HMODULE>(lib_handle), symbol); 17 return GetProcAddress(reinterpret_cast<HMODULE>(lib_handle), symbol);
21 } 18 }
OLDNEW
« no previous file with comments | « no previous file | runtime/bin/process_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698