Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: src/bootstrapper.cc

Issue 1156993018: GlobalDictionary now stores PropertyDetails in PropertyCells. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap-snapshot-generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/bootstrapper.cc
diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc
index 566188e3c5645fa818581314e63165f42da745ce..d8c98aaf418b3e6ed3814c1ccbf24eb4ac9129ee 100644
--- a/src/bootstrapper.cc
+++ b/src/bootstrapper.cc
@@ -2891,12 +2891,11 @@ void Genesis::TransferNamedProperties(Handle<JSObject> from,
CHECK_NE(LookupIterator::ACCESS_CHECK, it.state());
if (it.IsFound()) continue;
// Set the property.
- Handle<Object> value =
- Handle<Object>(properties->ValueAt(i), isolate());
- DCHECK(value->IsPropertyCell());
- value = handle(PropertyCell::cast(*value)->value(), isolate());
+ DCHECK(properties->ValueAt(i)->IsPropertyCell());
+ Handle<PropertyCell> cell(PropertyCell::cast(properties->ValueAt(i)));
+ Handle<Object> value(cell->value(), isolate());
if (value->IsTheHole()) continue;
- PropertyDetails details = properties->DetailsAt(i);
+ PropertyDetails details = cell->property_details();
DCHECK_EQ(kData, details.kind());
JSObject::AddProperty(to, key, value, details.attributes());
}
« no previous file with comments | « no previous file | src/heap-snapshot-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698