Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Unified Diff: lib/runtime/dart_runtime.js

Issue 1156993015: fixes #193, factory constructors as static methods (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/runtime/dart_runtime.js
diff --git a/lib/runtime/dart_runtime.js b/lib/runtime/dart_runtime.js
index 67cb4e23f5ed193a4637d85021027ba7086775b3..5761a8e897ef533aa8424e37297e0b2fbffbfb5e 100644
--- a/lib/runtime/dart_runtime.js
+++ b/lib/runtime/dart_runtime.js
@@ -151,12 +151,12 @@ var dart, _js_helper, _js_primitives;
if (obj instanceof Array && realRuntimeType(index) == core.int) {
return obj[index];
}
- return checkAndCall(obj.get, obj, [index], '[]');
+ return checkAndCall(obj.get, void 0, obj, [index], '[]');
}
dart.dindex = dindex;
function dsetindex(obj, index, value) {
- return checkAndCall(obj.set, obj, [index, value], '[]=');
+ return checkAndCall(obj.set, void 0, obj, [index, value], '[]=');
}
dart.dsetindex = dsetindex;
@@ -910,7 +910,7 @@ var dart, _js_helper, _js_primitives;
*/
// TODO(jmesserly): this could be faster
function map(values) {
- let map = new collection.LinkedHashMap();
+ let map = collection.LinkedHashMap.new();
vsm 2015/05/29 21:08:58 Hmm, it's too bad the JS user has to now keep trac
Jennifer Messerly 2015/05/29 21:32:17 yeah, seems kind of okay because: * the only way
if (Array.isArray(values)) {
for (let i = 0, end = values.length - 1; i < end; i += 2) {
let key = values[i];

Powered by Google App Engine
This is Rietveld 408576698