Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: Source/core/html/HTMLMediaElement.cpp

Issue 1156993013: New media playback UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed my own broken unit test. They really work! Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLMediaElement.cpp
diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp
index e905c8905d3cdb9f0a85e36d437d9eaacd134618..ca5f37366deae7a7851b20008fd103c2940268cf 100644
--- a/Source/core/html/HTMLMediaElement.cpp
+++ b/Source/core/html/HTMLMediaElement.cpp
@@ -3055,7 +3055,7 @@ void HTMLMediaElement::clearMediaPlayer(int flags)
m_remoteRoutesAvailable = false;
m_playingRemotely = false;
if (mediaControls())
- mediaControls()->refreshCastButtonVisibility();
+ mediaControls()->refreshCastButtonVisibilityWithoutUpdate();
if (m_textTracks)
configureTextTrackDisplay(AssumeNoVisibleChange);
@@ -3584,6 +3584,12 @@ bool HTMLMediaElement::isBlockedOnMediaController() const
return false;
}
+void HTMLMediaElement::setAllowHiddenAudioElements(bool allow)
+{
+ if (mediaControls())
philipj_slow 2015/07/14 11:16:22 ensureMediaControls() instead of the null check wo
liberato (no reviews please) 2015/07/14 22:10:37 done. i chose the null check because it's unclear
+ mediaControls()->setAllowHiddenAudioElements(allow);
+}
+
WebMediaPlayer::CORSMode HTMLMediaElement::corsMode() const
{
const AtomicString& crossOriginMode = fastGetAttribute(crossoriginAttr);

Powered by Google App Engine
This is Rietveld 408576698