Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: Source/core/html/shadow/MediaControls.h

Issue 1156993013: New media playback UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: manual rebaseline. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/shadow/MediaControls.h
diff --git a/Source/core/html/shadow/MediaControls.h b/Source/core/html/shadow/MediaControls.h
index 0c8f7ad3b959a3755d7dca5e027373463508189b..066d0bcb21f4b4463aca60e027fa923cf1fac4ca 100644
--- a/Source/core/html/shadow/MediaControls.h
+++ b/Source/core/html/shadow/MediaControls.h
@@ -68,6 +68,11 @@ public:
void refreshCastButtonVisibility();
void showOverlayCastButton();
+ // Update cast button visibility, but don't trigger a relayout. This
+ // can e called while stopping DOM objects, during which a layout
philipj_slow 2015/07/08 15:06:38 s/e/be/ but also see the comment about this not se
liberato (no reviews please) 2015/07/09 12:10:56 this method is now refreshCastButtonVisibilityWith
+ // can crash.
+ void refreshCastButtonVisibilityWithoutLayout();
+
void mediaElementFocused();
// Returns the layout object for the part of the controls that should be
@@ -103,6 +108,11 @@ private:
// element in the page, it will be hidden.
void tryShowOverlayCastButton();
+ // For the new UI, hide elements that don't fit, and show those things
+ // that we want that do fit.
+ void scheduleUpdateControlsVisibilityForSpace();
fs 2015/07/08 09:31:00 I don't know what the "ForSpace" suffix is suppose
liberato (no reviews please) 2015/07/09 12:10:56 it was intended to mean "based on what fits". i'l
+ void updateControlsVisibilityForSpace();
+
// Node
bool isMediaControls() const override { return true; }
bool willRespondToMouseMoveEvents() override { return true; }

Powered by Google App Engine
This is Rietveld 408576698