Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: LayoutTests/media/controls-volume-slider.html

Issue 1156993013: New media playback UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: manual rebaseline. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/media/controls-volume-slider.html
diff --git a/LayoutTests/media/controls-volume-slider.html b/LayoutTests/media/controls-volume-slider.html
index 4bd7497e739bee737b04bdbc1028269e23e8a0c5..44f2f4baae96d86292b5fda8dd86046a8d507235 100644
--- a/LayoutTests/media/controls-volume-slider.html
+++ b/LayoutTests/media/controls-volume-slider.html
@@ -14,14 +14,20 @@
testExpected("audio.volume", 1);
waitForEvent("loadedmetadata", function()
{
- // click the middle of the volume slider
- var coords = mediaControlsButtonCoordinates(audio, "volume-slider");
+ // Click at 25% of the volume slider, to avoid hitting
philipj_slow 2015/07/08 10:31:51 Perhaps this isn't a new bug, but now that the are
liberato (no reviews please) 2015/07/09 12:10:53 sounds good.
liberato (no reviews please) 2015/07/14 22:10:36 done.
+ // the thumb touch rectangle. That would cause no
+ // slider movement.
+ var slider = mediaControlsButton(audio, "volume-slider");
+ var boundingRect = slider.getBoundingClientRect();
+ coords = [ boundingRect.left + boundingRect.width * 0.25,
+ boundingRect.top + boundingRect.height / 2 ];
+
eventSender.mouseMoveTo(coords[0], coords[1]);
eventSender.mouseDown();
eventSender.mouseUp();
- testExpected("audio.volume", 0.4, '>');
- testExpected("audio.volume", 0.6, '<');
+ testExpected("audio.volume", 0.15, '>');
+ testExpected("audio.volume", 0.35, '<');
waitForEventAndEnd("volumechange");
});
</script>

Powered by Google App Engine
This is Rietveld 408576698