Source/core/html/HTMLMediaElement.cpp - Issue 1156993013: New media playback UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.cpp

Issue 1156993013: New media playback UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: cl feedback, rebased. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLMediaElement.cpp

diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp

index 63eda2639e62a01ca9a5fd97b8bdfc5a2bd153f8..7c2ea9312bbc6d2945f6e426197add329bdc22f5 100644

--- a/Source/core/html/HTMLMediaElement.cpp

+++ b/Source/core/html/HTMLMediaElement.cpp

@@ -3101,7 +3101,7 @@ void HTMLMediaElement::clearMediaPlayer(int flags)

m_remoteRoutesAvailable = false;

m_playingRemotely = false;

if (mediaControls())

- mediaControls()->refreshCastButtonVisibility();

+ mediaControls()->refreshCastButtonVisibilityWithoutUpdate();

if (layoutObject())

layoutObject()->setShouldDoFullPaintInvalidation();

@@ -3619,6 +3619,12 @@ bool HTMLMediaElement::isBlockedOnMediaController() const

return false;

}

+void HTMLMediaElement::setAllowHiddenVolumeControls(bool allow)

+ ensureMediaControls();

+ mediaControls()->setAllowHiddenVolumeControls(allow);

WebMediaPlayer::CORSMode HTMLMediaElement::corsMode() const

{

const AtomicString& crossOriginMode = fastGetAttribute(crossoriginAttr);