New media playback UI.

Source/core/html/shadow/SliderThumbElement.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 44 matching lines @@
 {
     ASSERT(input->layoutObject());
     const ComputedStyle& sliderStyle = input->layoutObject()->styleRef();
 
     return sliderStyle.appearance() == SliderVerticalPart;
 }
 
 inline SliderThumbElement::SliderThumbElement(Document& document)
     : HTMLDivElement(document)
     , m_inDragMode(false)
+    , m_didDragAnywhere(false)
 {
 }
 
 PassRefPtrWillBeRawPtr<SliderThumbElement> SliderThumbElement::create(Document& document)
 {
     RefPtrWillBeRawPtr<SliderThumbElement> element = adoptRefWillBeNoop(new SliderThumbElement(document));
     element->setAttribute(idAttr, ShadowElementNames::sliderThumb());
     return element.release();
 }
 
@@ skipping 87 matching lines @@
     }
 
     String valueString = serializeForNumberType(value);
     if (valueString == input->value())
         return;
 
     // FIXME: This is no longer being set from renderer. Consider updating the method name.
     input->setValueFromRenderer(valueString);
     if (layoutObject())
         layoutObject()->setNeedsLayoutAndFullPaintInvalidation(LayoutInvalidationReason::SliderValueChanged);
+
+    // We actually changed the value as part of a drag.
+    if (m_inDragMode)
+        m_didDragAnywhere = true;
 }
 
 void SliderThumbElement::startDragging()
 {
     if (LocalFrame* frame = document().frame()) {
         frame->eventHandler().setCapturingMouseEventsNode(this);
         m_inDragMode = true;
+        m_didDragAnywhere = false;
     }
 }
 
 void SliderThumbElement::stopDragging()
 {
     if (!m_inDragMode)
         return;
 
     if (LocalFrame* frame = document().frame())
         frame->eventHandler().setCapturingMouseEventsNode(nullptr);
@@ skipping 21 matching lines @@
     }
 
     MouseEvent* mouseEvent = toMouseEvent(event);
     bool isLeftButton = mouseEvent->button() == LeftButton;
     const AtomicString& eventType = event->type();
 
     // We intentionally do not call event->setDefaultHandled() here because
     // MediaControlTimelineElement::defaultEventHandler() wants to handle these
     // mouse events.
     if (eventType == EventTypeNames::mousedown && isLeftButton) {
+
+        m_mouseDownLocation = mouseEvent->absoluteLocation();
         startDragging();
         return;
     } else if (eventType == EventTypeNames::mouseup && isLeftButton) {
+        if (m_inDragMode && !m_didDragAnywhere && isMediaSlider()) {
+            // We got a down / up with no drag in between, and we're a media

[philipj_slow, 2015/07/21 12:02:21]

I don't think this is quite right. When you click anywhere outside the slider,
the position is updated on mousedown and then you can drag with the "thumb
element" centered under the mouse/touch point. This also seems to be the
behavior of YouTube.

I think the desired behavior can be implemented by removing the |targetNode !=
element()| bit from RangeInputType::handleMouseDownEvent and thus not have any
changes to this file.

If you would like to limit the change to the media controls, please add a TODO
and a bug to do it after a Blink roll or two, so that it can be separated out in
a bisect, but to leave the difference indefinitely seems strange.

[liberato (no reviews please), 2015/07/27 20:26:09]

i agree in principle, but i don't have enough experience to say whether the
broader change is okay.  since you do, and since you seem fairly confident that
it is okay, i'll do it now.

[philipj_slow, 2015/07/28 15:23:49]

It definitely is possible that the change will result in bug reports, and if
that happens let's hope we remember that this was part of the CL. Perhaps
mention it in the description. If you're more paranoid, you could also do it in
a separate CL before or after this.

[liberato (no reviews please), 2015/07/30 05:54:23]

i've reverted all of this, since we're now shipping android only.  desktop is
deferred.  android doesn't have the issue, since touch events in RangeInputType
don't care about the thumb.

i can put together a separate CL to change the slider behavior, which will also
make me feel better.  :)

+            // slider.  Jump to the touch down.
+            setPositionFromPoint(m_mouseDownLocation);
+        }
+
         stopDragging();
+
         return;
     } else if (eventType == EventTypeNames::mousemove) {
         if (m_inDragMode)
             setPositionFromPoint(mouseEvent->absoluteLocation());
         return;
     }
 
     HTMLDivElement::defaultEventHandler(event);
 }
 
@@ skipping 36 matching lines @@
     DEFINE_STATIC_LOCAL(const AtomicString, sliderThumb, ("-webkit-slider-thumb", AtomicString::ConstructFromLiteral));
     return sliderThumb;
 }
 
 static const AtomicString& mediaSliderThumbShadowPartId()
 {
     DEFINE_STATIC_LOCAL(const AtomicString, mediaSliderThumb, ("-webkit-media-slider-thumb", AtomicString::ConstructFromLiteral));
     return mediaSliderThumb;
 }
 
-const AtomicString& SliderThumbElement::shadowPseudoId() const
+bool SliderThumbElement::isMediaSlider() const
 {
     HTMLInputElement* input = hostInput();
     if (!input || !input->layoutObject())
-        return sliderThumbShadowPartId();
+        return false;
 
     const ComputedStyle& sliderStyle = input->layoutObject()->styleRef();
     switch (sliderStyle.appearance()) {
     case MediaSliderPart:
     case MediaSliderThumbPart:
     case MediaVolumeSliderPart:
     case MediaVolumeSliderThumbPart:
     case MediaFullScreenVolumeSliderPart:
     case MediaFullScreenVolumeSliderThumbPart:
+        return true;
+    default:
+        return false;
+    }
+}
+
+const AtomicString& SliderThumbElement::shadowPseudoId() const
+{
+    if (isMediaSlider())
         return mediaSliderThumbShadowPartId();
-    default:
-        return sliderThumbShadowPartId();
-    }
+    return sliderThumbShadowPartId();
 }
 
 // --------------------------------
 
 inline SliderContainerElement::SliderContainerElement(Document& document)
     : HTMLDivElement(document)
 {
 }
 
 DEFINE_NODE_FACTORY(SliderContainerElement)
@@ skipping 19 matching lines @@
     case MediaVolumeSliderThumbPart:
     case MediaFullScreenVolumeSliderPart:
     case MediaFullScreenVolumeSliderThumbPart:
         return mediaSliderContainer;
     default:
         return sliderContainer;
     }
 }
 
 }