Source/core/frame/Settings.in - Issue 1156993013: New media playback UI.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/frame/Settings.in

Issue 1156993013: New media playback UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: minor decrufting. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/core/css/mediaControlsAndroidNew.css ('K') | « Source/core/css/mediaControlsNew.css ('k') | Source/core/html/HTMLMediaElement.h » ('j') | Source/core/html/shadow/MediaControlElements.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Defines properties which are available on the Settings object.	1 # Defines properties which are available on the Settings object.

2 #	2 #

3 # Please think carefully before adding a new Setting. Some questions to	3 # Please think carefully before adding a new Setting. Some questions to

4 # consider are:	4 # consider are:

5 # - Should this be a RuntimeEnabledFeature instead? Settings are for things	5 # - Should this be a RuntimeEnabledFeature instead? Settings are for things

6 # which we support either values of at runtime. Features are set at renderer	6 # which we support either values of at runtime. Features are set at renderer

7 # process startup and are never changed. Features also tend to be set to a	7 # process startup and are never changed. Features also tend to be set to a

8 # value based on the platform or the stability of the code in question, where	8 # value based on the platform or the stability of the code in question, where

9 # as settings both codepaths need to be stable.	9 # as settings both codepaths need to be stable.

10 # - How will you ensure test coverage of all relevant values of your setting?	10 # - How will you ensure test coverage of all relevant values of your setting?

(...skipping 337 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
348 textTrackFontFamily type=String	348 textTrackFontFamily type=String

349 textTrackFontStyle type=String	349 textTrackFontStyle type=String

350 textTrackFontVariant type=String	350 textTrackFontVariant type=String

351 textTrackTextColor type=String	351 textTrackTextColor type=String

352 textTrackTextShadow type=String	352 textTrackTextShadow type=String

353 textTrackTextSize type=String	353 textTrackTextSize type=String

354	354

355 lowPriorityIframes initial=false	355 lowPriorityIframes initial=false

356	356

357 reportWheelOverscroll initial=false	357 reportWheelOverscroll initial=false

	358

	359 # Do we want to try to save screen real estate in the media player by hiding

	360 # the volume slider / mute button?

	361 preferHiddenAudioElements initial=false
	philipj_slow 2015/07/21 12:02:21 An audio element is <audio>, perhaps preferHiddenV An audio element is <audio>, perhaps preferHiddenVolumeControls? liberato (no reviews please) 2015/07/27 20:26:08 Done. Show quoted text On 2015/07/21 12:02:21, philipj wrote: > An audio element is <audio>, perhaps preferHiddenVolumeControls? Done.
OLD	NEW