LayoutTests/media/video-controls-hidden-audio.html - Issue 1156993013: New media playback UI.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/video-controls-hidden-audio.html

Issue 1156993013: New media playback UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: minor decrufting. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/media/video-controls-drop-order-expected.txt ('k') | LayoutTests/media/video-controls-hidden-audio-expected.txt » ('j') | Source/core/css/mediaControlsAndroidNew.css » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <video controls></video>

	2 <p>Test that hiding volume / mute buttons works as expected.</p>

	3 <script src=media-file.js></script>

	4 <script src=video-test.js></script>

	5 <script src=media-controls.js></script>

	6 <script>

	7 // Enable hidden audio preferences to take effect.

	8 run("window.internals.setAllowHiddenAudioElements(video, true)");

	9

	10 // Request non-hidden audio.

	11 run("window.internals.settings.setPreferHiddenAudioElements(false)");

	12

	13 // Starting with unmuted video,

	14 video.src = findMediaFile("video", "content/test");

	15 run("video.load()");

	16 waitForEvent("canplaythrough", function () {

	17 muteButton = mediaControlsButton(video, "mute-button");

	18 volumeSlider = mediaControlsButton(video, "volume-slider");

	19

	20 // Make sure that both are visible.

	21 testExpected("getComputedStyle(muteButton).display", "none", '!=');

	22 testExpected("getComputedStyle(volumeSlider).display", "none", '!=');

	23

	24 // Switch to muted video. Both should still be visible. We then

	25 // remind it that we'd like to allow hidden audio preferences, since

	26 // that also resets some state.

	27 run("video.muted = true");

	28 run("window.internals.setAllowHiddenAudioElements(video, true)");

	29 testExpected("getComputedStyle(muteButton).display", "none", '!=');

	30 testExpected("getComputedStyle(volumeSlider).display", "none", '!=');

	31

	32 run("window.internals.settings.setPreferHiddenAudioElements(true)");

	33

	34 // Switch back to unmuted video.

	35 run("video.muted = false");

	36 run("window.internals.setAllowHiddenAudioElements(video, true)");

	37

	38 testExpected("getComputedStyle(muteButton).display", "none", '==');

	39 testExpected("getComputedStyle(volumeSlider).display", "none", '==');

	40

	41 // For muted video, the volume slider will hide but the mute

	42 // button should come back, to let the user unmute.

	43 run("video.muted = true");

	44 run("window.internals.setAllowHiddenAudioElements(video, true)");

	45 testExpected("getComputedStyle(muteButton).display", "none", '!=');

	46 testExpected("getComputedStyle(volumeSlider).display", "none", '==');

	47

	48 endTest();

	49 });

	50 </script>

OLD	NEW