LayoutTests/media/video-controls-hidden-audio-expected.txt - Issue 1156993013: New media playback UI.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/video-controls-hidden-audio-expected.txt

Issue 1156993013: New media playback UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: cleaned up volume / mute hiding logic. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 Test that hiding volume / mute buttons works as expected.

	2

	3 RUN(window.internals.settings.setForceAllowHiddenAudioElements(true))

	4 RUN(window.internals.settings.setPreferHiddenVolumeSlider(false))

	5 RUN(window.internals.settings.setPreferHiddenMuteButton(false))

	6 RUN(video.load())

	7 EVENT(canplaythrough)

	8 EXPECTED (getComputedStyle(muteButton).display != 'none') OK

	9 EXPECTED (getComputedStyle(volumeSlider).display != 'none') OK

	10 RUN(video.muted = true)

	11 EXPECTED (getComputedStyle(muteButton).display != 'none') OK

	12 EXPECTED (getComputedStyle(volumeSlider).display != 'none') OK

	13 RUN(window.internals.settings.setPreferHiddenVolumeSlider(true))

	14 RUN(window.internals.settings.setPreferHiddenMuteButton(true))

	15 RUN(video.muted = false)

	16 EXPECTED (getComputedStyle(muteButton).display == 'none') OK

	17 EXPECTED (getComputedStyle(volumeSlider).display == 'none') OK

	18 RUN(video.muted = true)

	19 EXPECTED (getComputedStyle(muteButton).display != 'none') OK

	20 EXPECTED (getComputedStyle(volumeSlider).display == 'none') OK

	21 END OF TEST

	22

OLD	NEW