New media playback UI.

Source/core/html/shadow/MediaControls.h

 /*
  * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 49 matching lines @@
     void changedClosedCaptionsVisibility();
     void refreshClosedCaptionsButtonVisibility();
 
     void enteredFullscreen();
     void exitedFullscreen();
 
     void startedCasting();
     void stoppedCasting();
     void refreshCastButtonVisibility();
     void showOverlayCastButton();
+    void hideCastButtons();

[philipj_slow, 2015/07/09 08:56:11]

Ought this not be equivalent to refreshCastButtonVisibilityWithoutUpdate() in
the context it's called, i.e. when !mediaElement().hasRemoteRoutes()? It seems
like in principle it should be enough with just refreshCastButtonVisibility()
public, but cleaning up showOverlayCastButton() isn't your job if you don't want
it ;)

[liberato (no reviews please), 2015/07/09 22:35:35]

i originally had it that way, but decided that it was confusing in
HTMLMediaElement since it wasn't clear what an 'Update' was.  naming is one of
the three hardest problems in computer science, after all.

i've removed hide...() and replaced with refresh...Update().

[philipj_slow, 2015/07/10 14:51:58]

Acknowledged.

 
     void mediaElementFocused();
 
     // Returns the layout object for the part of the controls that should be
     // used for overlap checking during text track layout. May be null.
     LayoutObject* layoutObjectForTextTrackLayout();
 
+    // Notify us that our controls enclosure has changed width.
+    void notifyPanelWidthChanged(int panelWidth);
+
     DECLARE_VIRTUAL_TRACE();
 
 private:
     explicit MediaControls(HTMLMediaElement&);
 
     void initializeControls();
 
     void makeOpaque();
     void makeTransparent();
 
     void updatePlayState();
 
     enum HideBehaviorFlags {
         IgnoreNone = 0,
         IgnoreVideoHover = 1 << 0,
         IgnoreFocus = 1 << 1,
         IgnoreControlsHover = 1 << 2
     };
 
     bool shouldHideMediaControls(unsigned behaviorFlags = 0) const;
     void hideMediaControlsTimerFired(Timer<MediaControls>*);
     void startHideMediaControlsTimer();
     void stopHideMediaControlsTimer();
     void resetHideMediaControlsTimer();
 
     // Attempts to show the overlay cast button. If it is covered by another
     // element in the page, it will be hidden.
     void tryShowOverlayCastButton();
 
+    // After changing the want / don't want state of one or more controls,
+    // call this to recompute what's visible.
+    void changedControlSelections();
+
+    void panelWidthChangedTimerFired(Timer<MediaControls>*);
+
+    // For the new UI, hide elements that don't fit, and show those things

[philipj_slow, 2015/07/09 08:56:11]

Remove "For the new UI" or it's sure to be left in long after there's only one
UI.

[liberato (no reviews please), 2015/07/09 22:35:35]

Done.

+    // that we want that do fit.
+    void computeWhichControlsFit(int panelWidth);
+
+    // Update cast button visibility, but don't try to update our panel
+    // button visibility for space.
+    void refreshCastButtonVisibilityWithoutUpdate();
+
     // Node
     bool isMediaControls() const override { return true; }
     bool willRespondToMouseMoveEvents() override { return true; }
     void defaultEventHandler(Event*) override;
     bool containsRelatedTarget(Event*);
 
     RawPtrWillBeMember<HTMLMediaElement> m_mediaElement;
 
     // Media control elements.
     RawPtrWillBeMember<MediaControlOverlayEnclosureElement> m_overlayEnclosure;
     RawPtrWillBeMember<MediaControlOverlayPlayButtonElement> m_overlayPlayButton;
     RawPtrWillBeMember<MediaControlCastButtonElement> m_overlayCastButton;
     RawPtrWillBeMember<MediaControlPanelEnclosureElement> m_enclosure;
     RawPtrWillBeMember<MediaControlPanelElement> m_panel;
     RawPtrWillBeMember<MediaControlPlayButtonElement> m_playButton;
     RawPtrWillBeMember<MediaControlTimelineElement> m_timeline;
     RawPtrWillBeMember<MediaControlCurrentTimeDisplayElement> m_currentTimeDisplay;
     RawPtrWillBeMember<MediaControlTimeRemainingDisplayElement> m_durationDisplay;
     RawPtrWillBeMember<MediaControlMuteButtonElement> m_muteButton;
     RawPtrWillBeMember<MediaControlVolumeSliderElement> m_volumeSlider;
     RawPtrWillBeMember<MediaControlToggleClosedCaptionsButtonElement> m_toggleClosedCaptionsButton;
     RawPtrWillBeMember<MediaControlCastButtonElement> m_castButton;
     RawPtrWillBeMember<MediaControlFullscreenButtonElement> m_fullScreenButton;
 
     Timer<MediaControls> m_hideMediaControlsTimer;
     unsigned m_hideTimerBehaviorFlags;
     bool m_isMouseOverControls : 1;
     bool m_isPausedForScrubbing : 1;
+
+    Timer<MediaControls> m_panelWidthChangedTimer;
+    int m_panelWidth;
 };
 
 DEFINE_ELEMENT_TYPE_CASTS(MediaControls, isMediaControls());
 
 }
 
 #endif