New media playback UI.

Source/core/html/shadow/MediaControlElementTypes.h

 /*
  * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 57 matching lines @@
 };
 
 CORE_EXPORT HTMLMediaElement* toParentMediaElement(Node*);
 inline HTMLMediaElement* toParentMediaElement(LayoutObject* layoutObject) { return toParentMediaElement(layoutObject->node()); }
 
 CORE_EXPORT MediaControlElementType mediaControlElementType(Node*);
 
 // ----------------------------
 
 class MediaControlElement : public WillBeGarbageCollectedMixin {
-public:
+private:

[philipj_slow, 2015/07/09 08:56:09]

Move these things to the private section at the bottom instead. If you can
remove show() and hide() too, better to just have a single way (public or
private) to update the inline style.

[liberato (no reviews please), 2015/07/09 22:35:33]

Done.

     void hide();
     void show();
 
+    // hide() or show() based on our fits / wanted state.  We want to show()
+    // if an only if we're wanted and we fit.
+    void updateShownState();
+
+public:
+    bool isShown();
+
+    // These hold the state about whether this control should be shown if
+    // space permits.  These will also show / hide as needed.
+    void setIsWanted(bool);
+    bool isWanted();
+
+    // Tell us whether we fit or not.  This will hide / show the control as
+    // needed, also.
+    void setDoesFit(bool);
+
+    // This returns the minimum width in pixels that we need to show
+    // this control.  Ideally, this would just be shorthand for the computed
+    // style, but this must also work when the control is hidden.
+    int minimumWidth();
+
     MediaControlElementType displayType() { return m_displayType; }
 
     DECLARE_VIRTUAL_TRACE();
 
 protected:
     MediaControlElement(MediaControls&, MediaControlElementType, HTMLElement*);
 
     MediaControls& mediaControls() const { return m_mediaControls; }
     HTMLMediaElement& mediaElement() const;
 
     void setDisplayType(MediaControlElementType);
 
 private:
     MediaControls& m_mediaControls;
     MediaControlElementType m_displayType;
     RawPtrWillBeMember<HTMLElement> m_element;
+    bool m_isShown;

[philipj_slow, 2015/07/09 08:56:09]

Does this always equal m_isWanted && m_doesFit? If so remove it.

Also append ": 1" to consecutive bools to make them a bitfield.

[liberato (no reviews please), 2015/07/09 22:35:33]

Done.

+    bool m_isWanted;
+    bool m_doesFit;
 };
 
 // ----------------------------
 
 class MediaControlDivElement : public HTMLDivElement, public MediaControlElement {
     WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(MediaControlDivElement);
 public:
     DECLARE_VIRTUAL_TRACE();
 
 protected:
@@ skipping 29 matching lines @@
 protected:
     MediaControlTimeDisplayElement(MediaControls&, MediaControlElementType);
 
 private:
     double m_currentValue;
 };
 
 } // namespace blink
 
 #endif // MediaControlElementTypes_h