LayoutTests/media/video-controls-drop-order.html - Issue 1156993013: New media playback UI.

Side by Side Diff: LayoutTests/media/video-controls-drop-order.html

Issue 1156993013: New media playback UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: manual rebaseline. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/media/track/track-cue-rendering-wider-than-controls.html ('K') | « LayoutTests/media/track/track-cue-rendering-wider-than-controls.html ('k') | LayoutTests/media/video-controls-drop-order-expected.txt » ('j') | Source/core/css/CSSDefaultStyleSheets.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>
	philipj_slow 2015/07/08 14:37:34 https://www.chromium.org/blink/coding-style/layout https://www.chromium.org/blink/coding-style/layout-test-style-guidelines#TOC-... https://www.chromium.org/blink/coding-style/layout-test-style-guidelines#TOC-... To get rid of <body> you can simply put the test script at the end and not have an init() at all. liberato (no reviews please) 2015/07/09 12:10:53 Acknowledged. Show quoted text On 2015/07/08 14:37:34, philipj wrote: > https://www.chromium.org/blink/coding-style/layout-test-style-guidelines#TOC-... > https://www.chromium.org/blink/coding-style/layout-test-style-guidelines#TOC-... > > To get rid of <body> you can simply put the test script at the end and not have > an init() at all. Acknowledged.
	2 <head>

	3 <title>Test controls drop order</title>

	4 <script src=media-file.js></script>

	5 <script src=media-controls.js></script>

	6 <script src=video-test.js></script>

	7 <script>

	8 var numLoaded = 0;

	9 var videos = [];

	10 var controlNames = [

	11 "play-button",

	12 "timeline",

	13 "mute-button",

	14 "volume-slider",

	15 "fullscreen-button",

	16 "toggle-closed-captions-button",

	17 "time-remaining-display",

	18 "current-time-display",

	19 ];

	20

	21 function init()

	22 {

	23 var src = findMediaFile("video", "content/test");

	24 videos=[];
	philipj_slow 2015/07/08 14:37:34 videos is already set to [] videos is already set to [] liberato (no reviews please) 2015/07/09 12:10:54 Done. Show quoted text On 2015/07/08 14:37:34, philipj wrote: > videos is already set to [] Done.
	25 videoDiv = document.getElementById("videoDiv");

	26 for(var width = 50; width < 550; width+=50) {
	philipj_slow 2015/07/08 14:37:34 Spaces around operators. Spaces around operators. philipj_slow 2015/07/08 14:37:34 This will load quite a few videos in parallel. Can This will load quite a few videos in parallel. Can you be sure to run this test 1000 times or so locally to make sure it isn't flaky? I think there have been flaky video tests of this sort. liberato (no reviews please) 2015/07/09 12:10:53 Done. Show quoted text On 2015/07/08 14:37:34, philipj wrote: > Spaces around operators. Done. liberato (no reviews please) 2015/07/09 12:10:53 Done. Show quoted text On 2015/07/08 14:37:34, philipj wrote: > Spaces around operators. Done. liberato (no reviews please) 2015/07/09 12:10:54 Done. Show quoted text On 2015/07/08 14:37:34, philipj wrote: > Spaces around operators. Done.
	27 var video = document.createElement("video");

	28 videos.push(video);

	29 videoDiv.appendChild(video);

	30 video.addTextTrack('captions', 'English', 'en')

	31 .addCue(new VTTCue(0.0, 10.0, 'Some random caption text'));

	32 video.width = width;

	33 video.controls = true;

	34

	35 // wait for video to load

	36 video.addEventListener("canplay",videoLoaded);

	37 video.src = src;

	38 }

	39 }

	40

	41 function videoLoaded()

	42 {

	43 // One more video is ready.

	44 numLoaded++;

	45 if (numLoaded == videos.length) {

	46 // All videos are ready.

	47 test();

	48 }

	49 }

	50

	51 function displayButtonState(video)

	52 {

	53 var width = video.width;

	54

	55 for (var idx in controlNames) {
	philipj_slow 2015/07/08 14:37:34 Since these are plain arrays you could use "for (x Since these are plain arrays you could use "for (x of y)" here, seems like that's supported now. (forEach() would also have been an option) liberato (no reviews please) 2015/07/09 12:10:53 Done. Show quoted text On 2015/07/08 14:37:34, philipj wrote: > Since these are plain arrays you could use "for (x of y)" here, seems like > that's supported now. (forEach() would also have been an option) Done.
	56 var controlName = controlNames[idx];

	57 try {

	58 var control = mediaControlsButton(video, controlName);

	59 var state = (control.style['display'] != 'none') ? "seen" : "gone";
	philipj_slow 2015/07/08 14:37:34 Just control.style.display would be be idiomatic, Just control.style.display would be be idiomatic, or getComputedStyle() to be more robust against what it is that causes the control be display:none. liberato (no reviews please) 2015/07/09 12:10:55 Done. Show quoted text On 2015/07/08 14:37:34, philipj wrote: > Just control.style.display would be be idiomatic, or getComputedStyle() to be > more robust against what it is that causes the control be display:none. Done.
	60 consoleWrite(width + " " + state + " " + controlName);

	61 } catch (exception) {

	62 // control is missing

	63 consoleWrite("failed for " + width + " " + controlName + " " + exception);

	64 testRunner.notifyDone();
	philipj_slow 2015/07/08 14:37:34 Seems just as well to let the test finish running, Seems just as well to let the test finish running, so that all of the failures can be seen if it fails on the bots. liberato (no reviews please) 2015/07/09 12:10:56 Done. Show quoted text On 2015/07/08 14:37:34, philipj wrote: > Seems just as well to let the test finish running, so that all of the failures > can be seen if it fails on the bots. Done.
	65 }

	66 }

	67 }

	68

	69 function test()

	70 {

	71 for(var idx in videos) {

	72 displayButtonState(videos[idx]);

	73 }

	74 testRunner.notifyDone();

	75 }

	76 </script>

	77 </head>

	78 <body onload="init()">

	79 Tests that the drop order for controls doesn't change.<br>

	80 Output should be [video width in px] [seen or gone] [control name], with

	81 one line per control at each width.

	82 <div id="videoDiv"/>
	philipj_slow 2015/07/08 14:37:34 </div> if you want to close the div here, or someo </div> if you want to close the div here, or someone might think that this is XHTML at a glance. You could also do without this by simply appending the videos to document.body liberato (no reviews please) 2015/07/09 12:10:53 Done. Show quoted text On 2015/07/08 14:37:34, philipj wrote: > </div> if you want to close the div here, or someone might think that this is > XHTML at a glance. You could also do without this by simply appending the videos > to document.body Done.
	83 </body>

	84 </html>

OLD	NEW