LayoutTests/media/track/track-cue-rendering-wider-than-controls.html - Issue 1156993013: New media playback UI.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/track/track-cue-rendering-wider-than-controls.html

Issue 1156993013: New media playback UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: manual rebaseline. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/media/track/track-cue-rendering-after-controls-added-expected.html ('K') | « LayoutTests/media/track/track-cue-rendering-after-controls-added-expected.html ('k') | LayoutTests/media/video-controls-drop-order.html » ('j') | LayoutTests/media/video-controls-drop-order.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src=../media-file.js></script>	2 <script src=../media-file.js></script>

3 <script src=../video-test.js></script>	3 <script src=../video-test.js></script>

4 <script src=../media-controls.js></script>	4 <script src=../media-controls.js></script>

	5 <style>

	6 /* enforce a max width on the controls enclosure, so

	7 * that it doesn't fill the entire player width.

	8 */

	9 video::-webkit-media-controls-enclosure {
	philipj_slow 2015/07/08 10:31:51 A bit odd, but I guess this test can just be remov A bit odd, but I guess this test can just be removed when ::-webkit-media-* is removed and the max-width in mediaControls.css is no more. liberato (no reviews please) 2015/07/09 12:10:53 yeah, i was unsure whether to remove it now or wai Show quoted text On 2015/07/08 10:31:51, philipj wrote: > A bit odd, but I guess this test can just be removed when ::-webkit-media-* is > removed and the max-width in mediaControls.css is no more. yeah, i was unsure whether to remove it now or wait until the dust settles. i added it to my TODO list to be sure that it doesn't get lost.
	10 max-width: 800;

	11 }

	12 </style>

5 <script>	13 <script>

6 var controlsContainer;	14 var controlsContainer;

7 var cueRoot;	15 var cueRoot;

8	16

9 window.onload = function() {	17 window.onload = function() {

10 consoleWrite("Test that the cue root is not constrained by the controls/over lay.");	18 consoleWrite("Test that the cue root is not constrained by the controls/over lay.");

11 findMediaElement();	19 findMediaElement();

12 video.src = findMediaFile('video', '../content/test');	20 video.src = findMediaFile('video', '../content/test');

13 waitForEvent('seeked', function() {	21 waitForEvent('seeked', function() {

14 // The width of the controls depends on UA style, so verify that our ass umption holds.	22 // The width of the controls depends on UA style, so verify that our ass umption holds.

(...skipping 11 matching lines...) Expand all Loading...
26 </script>	34 </script>

27 <style>	35 <style>

28 video {	36 video {

29 width: 2000px;	37 width: 2000px;

30 height: 750px;	38 height: 750px;

31 }	39 }

32 </style>	40 </style>

33 <video controls>	41 <video controls>

34 <track src="captions-webvtt/long-word.vtt" default>	42 <track src="captions-webvtt/long-word.vtt" default>

35 </video>	43 </video>

OLD	NEW