LayoutTests/media/track/track-cue-rendering-after-controls-added-expected.html - Issue 1156993013: New media playback UI.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/track/track-cue-rendering-after-controls-added-expected.html

Issue 1156993013: New media playback UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: manual rebaseline. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/media/track/track-cue-rendering-after-controls-added.html ('K') | « LayoutTests/media/track/track-cue-rendering-after-controls-added.html ('k') | LayoutTests/media/track/track-cue-rendering-wider-than-controls.html » ('j') | LayoutTests/media/track/track-cue-rendering-wider-than-controls.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <title>Text track cue layout after controls are added (reference)</title>	2 <title>Text track cue layout after controls are added (reference)</title>

3 <style>	3 <style>

4 ::cue {	4 ::cue {

5 font-size: 50px;	5 font-size: 50px;

6 }	6 }

7 </style>	7 </style>

	8 <body>
	philipj_slow 2015/07/08 10:31:51 I don't think this change is needed to pass the te I don't think this change is needed to pass the test? (Many tests omit unnecessary markup in order to bring attention to the bits that are being tested.) liberato (no reviews please) 2015/07/09 12:10:53 Done. Show quoted text On 2015/07/08 10:31:51, philipj wrote: > I don't think this change is needed to pass the test? (Many tests omit > unnecessary markup in order to bring attention to the bits that are being > tested.) Done.
8 <video controls style="border:1px solid gray">	9 <video controls style="border:1px solid gray">

9 <source src="opera/track/webvtt/rendering/reftest/media/white.webm" type="vide o/webm">	10 <source src="opera/track/webvtt/rendering/reftest/media/white.webm" type="vide o/webm">

10 <source src="opera/track/webvtt/rendering/reftest/media/white.mp4" type="video /mp4">	11 <source src="opera/track/webvtt/rendering/reftest/media/white.mp4" type="video /mp4">

11 </video>	12 </video>

12 <script>	13 <script>

13 // Add a single cue at line -2, where it would be if there were controls visible	14 // Add a single cue at line -2, where it would be if there were controls visible

14 // at the bottom. (This assumes that those controls are less than 50px high.)	15 // at the bottom. (This assumes that those controls are less than 50px high.)

15 // cue at line -1.	16 // cue at line -1.

16 var video = document.querySelector("video");	17 var video = document.querySelector("video");

17 var track = video.addTextTrack("captions");	18 var track = video.addTextTrack("captions");

18 var cue = new VTTCue(0, 1, "text");	19 var cue = new VTTCue(0, 1, "text");

19 cue.line = -2;	20 cue.line = -2;

20 track.addCue(cue);	21 track.addCue(cue);

21 track.mode = "showing";	22 track.mode = "showing";

22 </script>	23 </script>

	24 </body>

	25 </html>

OLD	NEW