Source/core/paint/MediaControlsPainter.h - Issue 1156993013: New media playback UI.

Side by Side Diff: Source/core/paint/MediaControlsPainter.h

Issue 1156993013: New media playback UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/core/html/shadow/MediaControls.cpp ('K') | « Source/core/layout/LayoutThemeAndroid.cpp ('k') | Source/core/paint/MediaControlsPainter.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2009 Apple Inc.	2 * Copyright (C) 2009 Apple Inc.

3 * Copyright (C) 2009 Google Inc.	3 * Copyright (C) 2009 Google Inc.

4 * All rights reserved.	4 * All rights reserved.

5 *	5 *

6 * Redistribution and use in source and binary forms, with or without	6 * Redistribution and use in source and binary forms, with or without

7 * modification, are permitted provided that the following conditions	7 * modification, are permitted provided that the following conditions

8 * are met:	8 * are met:

9 * 1. Redistributions of source code must retain the above copyright	9 * 1. Redistributions of source code must retain the above copyright

10 * notice, this list of conditions and the following disclaimer.	10 * notice, this list of conditions and the following disclaimer.

(...skipping 31 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
42 static bool paintMediaPlayButton(LayoutObject*, const PaintInfo&, const IntR ect&);	42 static bool paintMediaPlayButton(LayoutObject*, const PaintInfo&, const IntR ect&);

43 static bool paintMediaToggleClosedCaptionsButton(LayoutObject*, const PaintI nfo&, const IntRect&);	43 static bool paintMediaToggleClosedCaptionsButton(LayoutObject*, const PaintI nfo&, const IntRect&);

44 static bool paintMediaSlider(LayoutObject*, const PaintInfo&, const IntRect& );	44 static bool paintMediaSlider(LayoutObject*, const PaintInfo&, const IntRect& );

45 static bool paintMediaSliderThumb(LayoutObject*, const PaintInfo&, const Int Rect&);	45 static bool paintMediaSliderThumb(LayoutObject*, const PaintInfo&, const Int Rect&);

46 static bool paintMediaVolumeSlider(LayoutObject*, const PaintInfo&, const In tRect&);	46 static bool paintMediaVolumeSlider(LayoutObject*, const PaintInfo&, const In tRect&);

47 static bool paintMediaVolumeSliderThumb(LayoutObject*, const PaintInfo&, con st IntRect&);	47 static bool paintMediaVolumeSliderThumb(LayoutObject*, const PaintInfo&, con st IntRect&);

48 static bool paintMediaFullscreenButton(LayoutObject*, const PaintInfo&, cons t IntRect&);	48 static bool paintMediaFullscreenButton(LayoutObject*, const PaintInfo&, cons t IntRect&);

49 static bool paintMediaOverlayPlayButton(LayoutObject*, const PaintInfo&, con st IntRect&);	49 static bool paintMediaOverlayPlayButton(LayoutObject*, const PaintInfo&, con st IntRect&);

50 static bool paintMediaCastButton(LayoutObject*, const PaintInfo&, const IntR ect&);	50 static bool paintMediaCastButton(LayoutObject*, const PaintInfo&, const IntR ect&);

51 static void adjustMediaSliderThumbSize(ComputedStyle&);	51 static void adjustMediaSliderThumbSize(ComputedStyle&);

	52

	53 private:

	54 static void adjustMediaSliderThumbPaintSize(const IntRect&, const ComputedSt yle&, IntRect& rectOut);
	philipj_slow 2015/06/17 12:52:25 Can't this simply return an IntRect by value? Even Can't this simply return an IntRect by value? Even with out C++11 move semantics there's a good chance it would fall under https://en.wikipedia.org/wiki/Return_value_optimization liberato (no reviews please) 2015/06/17 17:07:26 possibly, but it will end up being functionally th Show quoted text On 2015/06/17 12:52:25, philipj wrote: > Can't this simply return an IntRect by value? Even with out C++11 move semantics > there's a good chance it would fall under > https://en.wikipedia.org/wiki/Return_value_optimization possibly, but it will end up being functionally the same thing in the best case. to be sure, i fiddled around with clang. when it doesn't have the method body to inline, it seems to do better with the explicit out param. when it does have the method body, as it will in this case, it is more aggressive and they end up being almost identical.
52 };	55 };

53	56

54 } // namespace blink	57 } // namespace blink

55	58

56 #endif // MediaControlsPainter_h	59 #endif // MediaControlsPainter_h

OLD	NEW