LayoutTests/media/video-controls-mouse-events-captured.html - Issue 1156993013: New media playback UI.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/video-controls-mouse-events-captured.html

Issue 1156993013: New media playback UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: ...because i compiled release. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/media/track/track-cue-rendering-after-controls-added.html ('K') | « LayoutTests/media/video-controls-hidden-audio-expected.txt ('k') | LayoutTests/media/video-controls-muted-video-can-unmute.html » ('j') | Source/core/html/shadow/MediaControls.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4	4

5 </head>	5 </head>

6 <body>	6 <body>

7 <video controls></video>	7 <video controls></video>

8 <p>This tests that a mouse events on the controls will not be seen by the vi deo element.</p>	8 <p>This tests that a mouse events on the controls will not be seen by the vi deo element.</p>

9 <p>Also tests keyboard input.</p>	9 <p>Also tests keyboard input.</p>

10 <script src=media-file.js></script>	10 <script src=media-file.js></script>

(...skipping 27 matching lines...) Expand all Loading...
38 eventSender.keyDown('A');	38 eventSender.keyDown('A');

39	39

40 // Click the timeline - this tests that multilevel shadow DOM el ements work	40 // Click the timeline - this tests that multilevel shadow DOM el ements work

41 coords = mediaControlsButtonCoordinates(video, "timeline");	41 coords = mediaControlsButtonCoordinates(video, "timeline");

42 eventSender.mouseMoveTo(coords[0], coords[1]);	42 eventSender.mouseMoveTo(coords[0], coords[1]);

43	43

44 eventSender.mouseDown();	44 eventSender.mouseDown();

45 eventSender.mouseUp();	45 eventSender.mouseUp();

46 eventSender.keyDown('A');	46 eventSender.keyDown('A');

47	47

	48 // The above positioned the slider under the mouse. Click

	49 // to begin a drag.

	50 eventSender.mouseDown();
	philipj_slow 2015/08/05 08:41:05 Do you think it's worthwhile to test both with and Do you think it's worthwhile to test both with and without dragging? If it can be done within this test it seems worth it to me, otherwise maybe not. liberato (no reviews please) 2015/08/05 16:36:40 good idea. done. Show quoted text On 2015/08/05 08:41:05, philipj wrote: > Do you think it's worthwhile to test both with and without dragging? If it can > be done within this test it seems worth it to me, otherwise maybe not. good idea. done.
	51

48 waitForEventAndFail("mousemove")	52 waitForEventAndFail("mousemove")

49	53

50 // Check that the timeline also captures mousemove	54 // Check that the timeline also captures mousemove if the

	55 // slider is being dragged.

51 eventSender.mouseMoveTo(coords[0]+10, coords[1]+10)	56 eventSender.mouseMoveTo(coords[0]+10, coords[1]+10)

52 }	57 }

53 });	58 });

54 video.src = findMediaFile("video", "content/test");	59 video.src = findMediaFile("video", "content/test");

55 </script>	60 </script>

56 </body>	61 </body>

57 </html>	62 </html>

OLD	NEW