Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: runtime/vm/dart_api_state.h

Issue 1156993012: Fix for issue 23547, return an proper ApiError instead of a string when we report outstanding typed… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_state.h
diff --git a/runtime/vm/dart_api_state.h b/runtime/vm/dart_api_state.h
index 31be5fb405d46aebfaa82fd026eba213001ed57e..34b9f9a0995c0e380d888ee3ef39d4106c4392cd 100644
--- a/runtime/vm/dart_api_state.h
+++ b/runtime/vm/dart_api_state.h
@@ -818,10 +818,11 @@ class ApiState {
void SetupAcquiredError() {
ASSERT(acquired_error_ == NULL);
- acquired_error_ = persistent_handles().AllocateHandle();
- acquired_error_->set_raw(
+ const String& msg = String::Handle(
String::New("Internal Dart data pointers have been acquired, "
"please release them using Dart_TypedDataReleaseData."));
+ acquired_error_ = persistent_handles().AllocateHandle();
+ acquired_error_->set_raw(ApiError::New(msg));
}
PersistentHandle* AcquiredError() const {
« no previous file with comments | « runtime/vm/dart_api_impl_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698