Fix for issue 23547, return an proper ApiError instead of a string when we report outstanding typed…

runtime/vm/dart_api_state.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_DART_API_STATE_H_
 #define VM_DART_API_STATE_H_
 
 #include "include/dart_api.h"
 
 #include "platform/utils.h"
@@ skipping 800 matching lines @@
     ApiLocalScope* scope = top_scope_;
     while (scope != NULL) {
       total += scope->zone()->SizeInBytes();
       scope = scope->previous();
     }
     return total;
   }
 
   void SetupAcquiredError() {
     ASSERT(acquired_error_ == NULL);
-    acquired_error_ = persistent_handles().AllocateHandle();
-    acquired_error_->set_raw(
+    const String& msg = String::Handle(
         String::New("Internal Dart data pointers have been acquired, "
                     "please release them using Dart_TypedDataReleaseData."));
+    acquired_error_ = persistent_handles().AllocateHandle();
+    acquired_error_->set_raw(ApiError::New(msg));
   }
 
   PersistentHandle* AcquiredError() const {
     ASSERT(acquired_error_ != NULL);
     return acquired_error_;
   }
 
   WeakReferenceSetBuilder* NewWeakReferenceSetBuilder();
 
   void DelayWeakReferenceSet(WeakReferenceSet* reference_set);
@@ skipping 140 matching lines @@
   ref->set_peer(peer);
   ref->set_callback(callback);
   // This may trigger GC, so it must be called last.
   ref->SetExternalSize(external_size, isolate);
   return ref;
 }
 
 }  // namespace dart
 
 #endif  // VM_DART_API_STATE_H_