Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1156983002: Remove unused "Website Settings" view of content settings (Closed)

Created:
5 years, 7 months ago by raymes
Modified:
5 years, 6 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, msramek, tbuckley_google.com, scheib, Daniel Nishi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused "Website Settings" view of content settings This code has been unused for 8+months. BUG=492024 Committed: https://crrev.com/9a66ed01a85062d9ed2a70138597825bd1e4651f Cr-Commit-Position: refs/heads/master@{#332150}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2010 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/app/generated_resources.grd View 3 chunks +3 lines, -74 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/resources/options/browser_options.html View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/resources/options/browser_options.js View 2 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/resources/options/content_settings.html View 13 chunks +9 lines, -75 lines 0 comments Download
M chrome/browser/resources/options/content_settings.js View 2 chunks +0 lines, -23 lines 0 comments Download
M chrome/browser/resources/options/options.html View 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/resources/options/options.js View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/resources/options/options_bundle.js View 2 chunks +0 lines, -3 lines 0 comments Download
D chrome/browser/resources/options/origin_resources_list.js View 1 chunk +0 lines, -79 lines 0 comments Download
D chrome/browser/resources/options/website_settings.css View 1 chunk +0 lines, -168 lines 0 comments Download
D chrome/browser/resources/options/website_settings.html View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/resources/options/website_settings.js View 1 chunk +0 lines, -270 lines 0 comments Download
D chrome/browser/resources/options/website_settings_edit_page.js View 1 chunk +0 lines, -168 lines 0 comments Download
D chrome/browser/resources/options/website_settings_edit_site.html View 1 chunk +0 lines, -39 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 2 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/options/options_ui.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/browser/ui/webui/options/website_settings_browsertest.js View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/ui/webui/options/website_settings_handler.h View 1 chunk +0 lines, -143 lines 0 comments Download
D chrome/browser/ui/webui/options/website_settings_handler.cc View 1 chunk +0 lines, -833 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M components/content_settings/core/browser/content_settings_utils.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/content_settings/core/browser/content_settings_utils.cc View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 32 (8 generated)
raymes
5 years, 7 months ago (2015-05-26 05:09:47 UTC) #2
raymes
+jhawkins/tbuckley. Please let me know if you think we would want to keep any of ...
5 years, 7 months ago (2015-05-26 05:54:57 UTC) #4
James Hawkins
On 2015/05/26 05:54:57, raymes wrote: > +jhawkins/tbuckley. Please let me know if you think we ...
5 years, 7 months ago (2015-05-26 17:59:00 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156983002/40001
5 years, 7 months ago (2015-05-27 01:12:22 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-27 02:10:10 UTC) #9
raymes
Markus/Martin does this seem ok to you guys? If so I will get OWNERS approval. ...
5 years, 7 months ago (2015-05-27 02:28:52 UTC) #11
scheib
On 2015/05/27 02:28:52, raymes wrote: > Markus/Martin does this seem ok to you guys? If ...
5 years, 7 months ago (2015-05-27 04:29:35 UTC) #12
msramek
LGTM in the sense that I don't expect the code to be needed, but people ...
5 years, 7 months ago (2015-05-27 17:01:53 UTC) #14
raymes
On 2015/05/27 17:01:53, msramek wrote: > LGTM in the sense that I don't expect the ...
5 years, 7 months ago (2015-05-28 03:56:19 UTC) #15
raymes
jhawkins: could you please give OWNERS for the stuff in chrome/ markusheintz: could you please ...
5 years, 7 months ago (2015-05-28 03:59:12 UTC) #16
markusheintz_
On 2015/05/28 03:59:12, raymes wrote: > jhawkins: could you please give OWNERS for the stuff ...
5 years, 6 months ago (2015-05-29 15:24:04 UTC) #17
markusheintz_
On 2015/05/28 03:59:12, raymes wrote: > jhawkins: could you please give OWNERS for the stuff ...
5 years, 6 months ago (2015-05-29 15:24:07 UTC) #18
markusheintz_
On 2015/05/29 15:24:07, markusheintz_ wrote: > On 2015/05/28 03:59:12, raymes wrote: > > jhawkins: could ...
5 years, 6 months ago (2015-05-29 15:26:38 UTC) #20
James Hawkins
lgtm
5 years, 6 months ago (2015-05-29 16:39:26 UTC) #21
felt
Based on a recent thread about this code, it's OK to delete because the Material ...
5 years, 6 months ago (2015-05-29 17:24:54 UTC) #22
James Hawkins
On 2015/05/29 17:24:54, felt wrote: > Based on a recent thread about this code, it's ...
5 years, 6 months ago (2015-05-29 17:31:39 UTC) #23
felt
On 2015/05/29 17:31:39, James Hawkins wrote: > On 2015/05/29 17:24:54, felt wrote: > > Based ...
5 years, 6 months ago (2015-05-29 17:46:51 UTC) #24
James Hawkins
On 2015/05/29 17:46:51, felt wrote: > On 2015/05/29 17:31:39, James Hawkins wrote: > > On ...
5 years, 6 months ago (2015-05-29 17:49:47 UTC) #25
felt
On 2015/05/29 17:49:47, James Hawkins wrote: > On 2015/05/29 17:46:51, felt wrote: > > On ...
5 years, 6 months ago (2015-05-29 17:51:03 UTC) #26
James Hawkins
On 2015/05/29 17:51:03, felt wrote: > On 2015/05/29 17:49:47, James Hawkins wrote: > > On ...
5 years, 6 months ago (2015-05-29 17:55:04 UTC) #27
raymes
On 2015/05/29 17:55:04, James Hawkins wrote: > On 2015/05/29 17:51:03, felt wrote: > > On ...
5 years, 6 months ago (2015-06-01 00:20:15 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156983002/40001
5 years, 6 months ago (2015-06-01 00:20:31 UTC) #30
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-01 01:32:33 UTC) #31
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 01:33:19 UTC) #32
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9a66ed01a85062d9ed2a70138597825bd1e4651f
Cr-Commit-Position: refs/heads/master@{#332150}

Powered by Google App Engine
This is Rietveld 408576698