Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 1156973002: [bindings] Use |PostMessage| attribute for DedicatedWorkerGlobalScope.postMessage to eliminate cust… (Closed)

Created:
5 years, 7 months ago by vivekg_samsung
Modified:
5 years, 7 months ago
Reviewers:
haraken, kinuko, falken, vivekg
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, Inactive, falken, horo+watch_chromium.org, kinuko+worker_chromium.org, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[bindings] Use |PostMessage| attribute for DedicatedWorkerGlobalScope.postMessage to eliminate custom bindings As the code is using the binding code generator for the |postMessage|, the interfaceName is derived from the |interface_name|. To align to this scheme, the layout tests have been modified to receive the exception object with interface name as the |interface_name|. BUG=345519 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195893

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -55 lines) Patch
M LayoutTests/fast/workers/worker-context-multi-port-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/workers/worker-formdata-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/workers/worker-multi-port-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/workers/worker-onerror-09.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/workers/worker-onerror-09-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D Source/bindings/core/v8/custom/V8DedicatedWorkerGlobalScopeCustom.cpp View 1 chunk +0 lines, -45 lines 0 comments Download
M Source/bindings/core/v8/custom/custom.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/workers/DedicatedWorkerGlobalScope.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
vivekg
PTAL, thanks. PS: For the context, the CL [1] has introduced |PostMessage| IDL extended attribute ...
5 years, 7 months ago (2015-05-26 03:49:56 UTC) #2
haraken
From the perspective of bindings, this looks good.
5 years, 7 months ago (2015-05-26 03:51:40 UTC) #3
haraken
LGTM but let's wait for worker guy's approval.
5 years, 7 months ago (2015-05-26 04:11:38 UTC) #4
vivekg
On 2015/05/26 at 04:11:38, haraken wrote: > LGTM but let's wait for worker guy's approval. ...
5 years, 7 months ago (2015-05-26 04:13:43 UTC) #5
kinuko
LGTM, nice that we can now get rid of the custom code.
5 years, 7 months ago (2015-05-26 06:24:10 UTC) #6
vivekg
On 2015/05/26 at 06:24:10, kinuko wrote: > LGTM, nice that we can now get rid ...
5 years, 7 months ago (2015-05-26 06:33:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156973002/1
5 years, 7 months ago (2015-05-26 06:51:25 UTC) #9
kinuko
On 2015/05/26 06:33:22, vivekg_ wrote: > On 2015/05/26 at 06:24:10, kinuko wrote: > > LGTM, ...
5 years, 7 months ago (2015-05-26 06:54:43 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-26 07:00:52 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195893

Powered by Google App Engine
This is Rietveld 408576698