Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: tools/auto_bisect/bisect_utils.py

Issue 1156963003: Fix confidence check and problems with successive builds due to symlinks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix for invalid confidence was wrong; now correct Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/auto_bisect/bisect_perf_regression.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/auto_bisect/bisect_utils.py
diff --git a/tools/auto_bisect/bisect_utils.py b/tools/auto_bisect/bisect_utils.py
index 0d7f5065f8682c73683e258284041826768bd754..82fc93fdc241a9aa925e646439400f4bb6c14fd5 100644
--- a/tools/auto_bisect/bisect_utils.py
+++ b/tools/auto_bisect/bisect_utils.py
@@ -475,7 +475,7 @@ def CreateBisectDirectoryAndSetupDepot(opts, custom_deps):
raise RuntimeError('Failed to grab source.')
-def RunProcess(command):
+def RunProcess(command, cwd=None, shell=False):
"""Runs an arbitrary command.
If output from the call is needed, use RunProcessAndRetrieveOutput instead.
@@ -487,8 +487,8 @@ def RunProcess(command):
The return code of the call.
"""
# On Windows, use shell=True to get PATH interpretation.
- shell = IsWindowsHost()
- return subprocess.call(command, shell=shell)
+ shell = shell or IsWindowsHost()
+ return subprocess.call(command, cwd=cwd, shell=shell)
def RunProcessAndRetrieveOutput(command, cwd=None):
« no previous file with comments | « tools/auto_bisect/bisect_perf_regression.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698