Issue 115693002: Remove several calls to Page::mainFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115693002: Remove several calls to Page::mainFrame (Closed)

Created:
7 years ago by eseidel

Modified:
7 years ago

Reviewers:
abarth-chromium

CC:
blink-reviews, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, Nils Barth (inactive), caseq+blink_chromium.org, Nate Chapin, arv+blink, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, devtools-reviews_chromium.org, kenneth.christiansen, loislo+blink_chromium.org, sof, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, darktears, haraken, kojih, jsbell+bindings_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman, Inactive, site-isolation-reviews_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove several calls to Page::mainFrame All of these callers either didn't need to use the mainFrame (as in the case of the MediaQuery functions which called PlatformScreen functions which already jumped to the top-most Widget automatically) or could get the information they need by asking the Frame directly. There were a couple cases in the inspector where checking Frame::isMainFrame() wouldn't be identical, so I've left those as FIXMEs for now. R=abarth@chromium.org BUG=305811 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163921

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -12 lines)			Patch
M	Source/bindings/v8/custom/V8WindowCustom.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/core/css/MediaQueryEvaluator.cpp	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	Source/core/inspector/InspectorDOMAgent.cpp	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	Source/core/inspector/InspectorDatabaseAgent.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/core/inspector/InspectorPageAgent.cpp	View	1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/115693002/1

7 years ago (2013-12-15 06:06:25 UTC) #4

Message was sent while issue was closed.

Change committed as 163921

Expand Messages | Collapse Messages