Issue 1156923006: Install google appengine.

Issue 1156923006: Install google appengine. (Closed)

Created:
5 years, 6 months ago by Adrian Kuegel

Modified:
5 years, 6 months ago

Reviewers:
pgervais

CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Target Ref:
refs/remotes/origin/master

Project:
tools

Visibility:
Public.

Install google appengine. This is needed to run the presubmit commit checks. Tested this CL by running git cl presubmit locally. BUG=420910 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295472

Total comments: 2

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+149 lines, -15 lines)			Patch
	A	testing_support/get_appengine.py	View	1 2	1 chunk	+139 lines, -0 lines	0 comments	Download
	M	testing_support/local_rietveld.py	View	1 2 3	1 chunk	+10 lines, -15 lines	0 comments	Download

Total messages: 11 (4 generated)

pgervais

I think copying get_appengine.py to depot_tools is safer and would be simpler. It would get ...

5 years, 6 months ago (2015-05-28 20:51:46 UTC) #4

Adrian Kuegel

Agree, that is a lot simpler. This also makes the code where you had comments ...

5 years, 6 months ago (2015-05-29 08:18:03 UTC) #5

pgervais

On 2015/06/01 08:58:05, Adrian Kuegel wrote: > Philippe, can you please take another look? lgtm. ...

5 years, 6 months ago (2015-06-01 15:34:05 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156923006/90001

5 years, 6 months ago (2015-06-01 15:50:35 UTC) #10

commit-bot: I haz the power

5 years, 6 months ago (2015-06-01 15:53:51 UTC) #11

Message was sent while issue was closed.

Committed patchset #4 (id:90001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295472