Add a pub command for managing uploaders for packages.

utils/pub/command_uploader.dart

+// Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+library command_uploader;
+
+import 'dart:io';
+import 'dart:uri';
+
+import '../../pkg/args/lib/args.dart';
+import 'entrypoint.dart';
+import 'exit_codes.dart' as exit_codes;
+import 'io.dart';
+import 'log.dart' as log;
+import 'oauth2.dart' as oauth2;
+import 'path.dart' as path;
+import 'pub.dart';
+
+/// Handles the `uploader` pub command.
+class UploaderCommand extends PubCommand {
+  final description = "Manage uploaders for a package on pub.dartlang.org.";
+  final usage = "pub uploader [options] {add/remove} email";

[Bob Nystrom, 2012/12/17 18:41:58]

"email" -> "<email>"

[nweiz, 2012/12/17 21:18:48]

Done.

+  final requiresEntrypoint = false;
+
+  ArgParser get commandParser {
+    var parser = new ArgParser();
+    parser.addOption('server', defaultsTo: 'https://pub.dartlang.org',

[Bob Nystrom, 2012/12/17 18:41:58]

Instead of a literal URI here, how about we make that a constant in
hosted_source?

[nweiz, 2012/12/17 21:18:48]

Right now using the hosted_source constant won't work, because we want to use
HTTPS for requests that include OAuth2 credentials but we don't want to use cURL
for just downloading packages. I'll add a TODO for that, though.

+        help: 'The package server to which to upload this package');

[Bob Nystrom, 2012/12/17 18:41:58]

Make this relevant to this command.

[nweiz, 2012/12/17 21:18:48]

Done.

+    parser.addOption('package', help: 'The package whose uploaders will be '
+        'modified\n'
+        '(defaults to the current package)');
+    return parser;
+  }
+
+  /// The URL of the package hosting server.
+  Uri get server => new Uri.fromString(commandOptions['server']);

[Bob Nystrom, 2012/12/17 18:41:58]

Does this fail gracefully if the argument isn't a valid URL?

[nweiz, 2012/12/17 21:18:48]

I don't think Uri.fromString throws any parse errors - it'll do its best to
interpret any string. cURL will generate a reasonably sensible error, though.

+
+  Future onRun() {
+    if (commandOptions.rest.isEmpty) {
+      log.error('No uploader command given.');
+      this.printUsage();
+      exit(exit_codes.USAGE);
+    }
+
+    var command = commandOptions.rest.removeAt(0);

[Bob Nystrom, 2012/12/17 18:41:58]

I think sometime soon I want to add real command support to args. I've been
waiting until we had some solid use code that needed it, and I think pub is at
the point no where it can be used to prove out the API.

[nweiz, 2012/12/17 21:18:48]

I thought about doing that here, but decided this would be easier for the time
being. It would be nice, though.

+    if (!['add', 'remove'].contains(command)) {
+      log.error('Unknown uploader command "$command".');
+      this.printUsage();
+      exit(exit_codes.USAGE);
+    } else if (commandOptions.rest.isEmpty) {
+      log.error('No package or uploader given for "pub uploader $command".');
+      this.printUsage();
+      exit(exit_codes.USAGE);
+    }
+
+    return new Future.immediate(null).chain((_) {
+      var package = commandOptions['package'];
+      if (package != null) return new Future.immediate(package);
+      return Entrypoint.load(path.current, cache)
+          .transform((entrypoint) => entrypoint.root.name);
+    }).chain((package) {
+      var uploader = commandOptions.rest[0];
+      return oauth2.withClient(cache, (client) {
+        if (command == 'add') {
+          var url = server.resolve("/packages/${encodeUriComponent(package)}"
+              "/uploaders.json");
+          return client.post(url, fields: {"email": uploader});
+        } else { // command == 'remove'
+          var url = server.resolve("/packages/${encodeUriComponent(package)}"
+              "/uploaders/${encodeUriComponent(uploader)}.json");
+          return client.delete(url);
+        }
+      });
+    }).transform(handleJsonSuccess).transformException((e) {
+      if (e is! PubHttpException) throw e;
+      handleJsonError(e.response);
+    });
+  }
+}