tests/PathTest.cpp - Issue 1156893003: simplify RawIter - don't return a pt in kClose

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/PathTest.cpp

Issue 1156893003: simplify RawIter - don't return a pt in kClose (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/PathTest.cpp

diff --git a/tests/PathTest.cpp b/tests/PathTest.cpp

index b78b343ccc6b3fe32393a6d73045340bcd066c3c..d25d349d4b216074f796c40d822b70b0d2948b3b 100644

--- a/tests/PathTest.cpp

+++ b/tests/PathTest.cpp

@@ -2602,14 +2602,10 @@ static void test_raw_iter(skiatest::Reporter* reporter) {

REPORTER_ASSERT(reporter, pts[0].fX == SK_Scalar1);

REPORTER_ASSERT(reporter, pts[0].fY == 0);

REPORTER_ASSERT(reporter, iter.next(pts) == SkPath::kClose_Verb);

- REPORTER_ASSERT(reporter, pts[0].fX == SK_Scalar1);

- REPORTER_ASSERT(reporter, pts[0].fY == 0);

REPORTER_ASSERT(reporter, iter.next(pts) == SkPath::kMove_Verb);

REPORTER_ASSERT(reporter, pts[0].fX == SK_Scalar1*2);

REPORTER_ASSERT(reporter, pts[0].fY == SK_Scalar1);

REPORTER_ASSERT(reporter, iter.next(pts) == SkPath::kClose_Verb);

- REPORTER_ASSERT(reporter, pts[0].fX == SK_Scalar1*2);

- REPORTER_ASSERT(reporter, pts[0].fY == SK_Scalar1);

REPORTER_ASSERT(reporter, iter.next(pts) == SkPath::kMove_Verb);

REPORTER_ASSERT(reporter, pts[0].fX == SK_Scalar1*3);

REPORTER_ASSERT(reporter, pts[0].fY == SK_Scalar1*2);

@@ -2617,8 +2613,6 @@ static void test_raw_iter(skiatest::Reporter* reporter) {

REPORTER_ASSERT(reporter, pts[0].fX == SK_Scalar1*4);

REPORTER_ASSERT(reporter, pts[0].fY == SK_Scalar1*3);

REPORTER_ASSERT(reporter, iter.next(pts) == SkPath::kClose_Verb);

- REPORTER_ASSERT(reporter, pts[0].fX == SK_Scalar1*4);

- REPORTER_ASSERT(reporter, pts[0].fY == SK_Scalar1*3);

REPORTER_ASSERT(reporter, iter.next(pts) == SkPath::kDone_Verb);

// Generate random paths and verify

@@ -2761,7 +2755,6 @@ static void test_raw_iter(skiatest::Reporter* reporter) {

numIterPts += 3;

break;

case SkPath::kClose_Verb:

- REPORTER_ASSERT(reporter, pts[0] == lastMoveTo);

lastPt = lastMoveTo;

break;

default:

« no previous file with comments | « src/core/SkPath.cpp ('k') | no next file » | no next file with comments »