Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1156883004: Fix color pickers on WebView. (Closed)

Created:
5 years, 6 months ago by Torne
Modified:
5 years, 6 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix color pickers on WebView. Instead of getting the activity from the WindowAndroid to use as a context, just get the context from the ContentViewCore. In WebView, contexts must be wrapped to enable proper class lookup for custom view classes defined in the WebView APK and using the Activity directly was circumventing the wrapper, causing color pickers to crash. BUG=490616 Committed: https://crrev.com/2046d4f5a4bde936c772262f73eb91d62f100b5b Cr-Commit-Position: refs/heads/master@{#332418}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -12 lines) Patch
M components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/ColorChooserAndroid.java View 2 chunks +3 lines, -6 lines 0 comments Download
M components/web_contents_delegate_android/color_chooser_android.cc View 2 chunks +17 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Torne
5 years, 6 months ago (2015-06-02 14:52:52 UTC) #2
Ted C
lgtm
5 years, 6 months ago (2015-06-02 16:43:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156883004/1
5 years, 6 months ago (2015-06-02 16:44:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-02 17:22:44 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 17:23:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2046d4f5a4bde936c772262f73eb91d62f100b5b
Cr-Commit-Position: refs/heads/master@{#332418}

Powered by Google App Engine
This is Rietveld 408576698